On Sun Feb 23, 2025 at 4:59 AM CET, Matthias Babisch wrote:
> Am 21.02.25 um 08:11 schrieb Salvatore Bonaccorso:
>> On Wed, Feb 19, 2025 at 01:40:35PM +0100, Matthias Babisch wrote:
>>> Package: src:linux
>>> Version: 6.1.124-1
>>>
>>> System is unaffected if running older kernel. I have two systems. They both
>>> work if running the older kernel, both don't when running the newer kernel.
>> I think this is the same as 1098250 and 1095745.
>>
>> See:https://lore.kernel.org/lkml/20250106100001.1344418-2-amad...@jmu.edu.cn/
>>
> I see a strong similarity to 1098250. Lesser so to 1095745 and the 
> patch. But it could very well be.
>
> Its just way beyond my level of expertise ;o) Any idea when the patch is 
> entering the debian kernel? I would gladly test a preliminary package if 
> that helps. Thank you very much. Matthias Babisch

The following link describes a (relatively) simple way to test a patch:
https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#id-1.6.6.4

I've adapted the patch to the 6.1 kernel so it _should_ work, but
haven't tried it myself. With your freshly build kernel you can verify
if it indeed fixes the problem for 6.1 kernels.

HTH,
  Diederik
From 2d9a71ef38e139668dff7bc8a54df9fa37677649 Mon Sep 17 00:00:00 2001
From: Chukun Pan <amad...@jmu.edu.cn>
Date: Mon, 6 Jan 2025 18:00:01 +0800
Subject: [PATCH] phy: rockchip: naneng-combphy: compatible reset with old DT

The device tree of RK3568 did not specify reset-names before.
So add fallback to old behaviour to be compatible with old DT.

Fixes: fbcbffbac994 ("phy: rockchip: naneng-combphy: fix phy reset")
Cc: Jianfeng Liu <liujianfeng1...@gmail.com>
Signed-off-by: Chukun Pan <amad...@jmu.edu.cn>
Reviewed-by: Jonas Karlman <jo...@kwiboo.se>
Link: https://lore.kernel.org/r/20250106100001.1344418-2-amad...@jmu.edu.cn
Signed-off-by: Vinod Koul <vk...@kernel.org>
---
 drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
index d97a7164c496..2c73cc8dd1ed 100644
--- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
@@ -299,7 +299,10 @@ static int rockchip_combphy_parse_dt(struct device *dev, struct rockchip_combphy
 
 	priv->ext_refclk = device_property_present(dev, "rockchip,ext-refclk");
 
-	priv->phy_rst = devm_reset_control_get(dev, "phy");
+	priv->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
+	/* fallback to old behaviour */
+	if (PTR_ERR(priv->phy_rst) == -ENOENT)
+		priv->phy_rst = devm_reset_control_array_get_exclusive(dev);
 	if (IS_ERR(priv->phy_rst))
 		return dev_err_probe(dev, PTR_ERR(priv->phy_rst), "failed to get phy reset\n");
 
-- 
2.47.2

Attachment: signature.asc
Description: PGP signature

Reply via email to