Package: firmware-siano
Version: 20230210-5
Tags: patch
User: p...@hungry.com
Usertags: appstream-modalias
Here is a draft patch to add Appstream metainfo XML announcing the
hardware handled by this package. I was unable to figure out the build
system, so I could not test the patch.
Including this information in the package will ensure programs mapping
hardware to packages using Appstream information, like the isenkram
package, will know that this package is useful on machines where the
hardware is discovered.
The appstream metadata file can be checked using this command after
package build:
appstreamcli validate-tree --no-net --explain debian/uhd-host
I renamed the metainfo.xml file to match the ID used in the XML file, to
fix a warning reported by the validator. I suspect a similar change
should be done for every firmware package, but decided to only fix the
package where I have a modalias proposal, to keep the patch small.
diff --git a/debian/firmware-siano.install b/debian/firmware-siano.install
new file mode 100644
index 0000000..64fb409
--- /dev/null
+++ b/debian/firmware-siano.install
@@ -0,0 +1 @@
+debian/org.debian.packages.firmware_siano.metainfo.xml usr/share/metainfo
diff --git a/debian/firmware-siano.metainfo.xml
b/debian/org.debian.packages.firmware_siano.metainfo.xml
similarity index 96%
rename from debian/firmware-siano.metainfo.xml
rename to debian/org.debian.packages.firmware_siano.metainfo.xml
index e9ed916..a3a84c2 100644
--- a/debian/firmware-siano.metainfo.xml
+++ b/debian/org.debian.packages.firmware_siano.metainfo.xml
@@ -18,6 +18,6 @@
<firmware type="runtime">sms1xxx-nova-b-dvbt-01.fw</firmware>
<firmware type="runtime">sms1xxx-stellar-dvbt-01.fw</firmware>
<firmware type="runtime">tdmb_nova_12mhz.inp</firmware>
-
+ <modalias>usb:v187Fp0201d*</modalias>
</provides>
</component>
diff --git a/debian/rules.real b/debian/rules.real
index dbb5052..68d89b2 100644
--- a/debian/rules.real
+++ b/debian/rules.real
@@ -28,7 +28,8 @@ install:
done
ifneq ($(FILES),)
dh_installdirs /usr/share/metainfo
- dh_install debian/$(PACKAGE_NAME).metainfo.xml /usr/share/metainfo
+ ( [ -e debian/$(PACKAGE_NAME).metainfo.xml ] && \
+ dh_install debian/$(PACKAGE_NAME).metainfo.xml /usr/share/metainfo )
|| true
endif
dh_bugfiles
dh_installchangelogs
--
Happy hacking
Petter Reinholdtsen
