Control: retitle -1 Thinkpad: amd_pmc module required for on 6.1 for correct suspend
Le mardi, 17 janvier 2023, 22.53:54 h CET Didier 'OdyX' Raboud a écrit : > Le mardi, 17 janvier 2023, 15.32:37 h CET Diederik de Haas a écrit : > > On Monday, 16 January 2023 22:33:05 CET Didier 'OdyX' Raboud wrote: > > > This is on 6.1.4-1a~test, patched against the "2nd DisplayPort doesn't > > > light up", so feel free to close the bug; I'll test if I get the same > > > symptoms on an unpatched kernel anyway :-) > > > > If this issue doesn't occur with the unpatched kernel, that would be VERY > > important extra information! > > https://gitlab.freedesktop.org/drm/amd/-/issues/2171#note_1724186 may be > > the same or similar finding? > > > > If that issue doesn't occur with the unpatched kernel, could you add your > > finding to that upstream/forwarded issue? > > Now that I got my kernel build in place; I can actually confirm that: > > On my Thinkpad X13 Gen 2a, without any dongle, hub or docking station (on > battery), with a KDE Plasma Wayland session: > > * 6.0.0-6-amd64 (6.0.12-1) > suspends and resumes correctly > * 6.1.0-1-amd64 (6.1.4-1, unpatched) > doesn't finish suspending > * 6.1.0-2-amd64 (6.1.6-1, from the 'sid' branch on salsa, not patched) > doesn't finish suspending > * 6.1.0-2-amd64 (6.1.6-1, from the 'sid' branch on salsa, patched), > doesn't finish suspending > > All three 6.1 kernels (whether patched or not) don't bring the laptop to the > suspended state (power led 'breathing', fans off), but it's kept in an "on" > state (power led on, fans on), from which I found that I *can* wake the > laptop up by short-pressing the power button; the screens gets back to life > and show my lockscreen. But from there, I can't move the mouse nor do > anything else. Alt-SysRq-r + ctrl-alt-f2 give me a tty, but any comeback to > tty1 only blank (not even a blank screen, just a freeze). > > This seems to point to a quite severe regression in amdgpu or other amd- > related code; I can't suspend-and-resume the laptop anymore on any 6.1 > kernel, on battery, without anything attached to it. > > I'll forward the above findings to the bug you pointed to, hoping it could > help upstream too! OK. I've gone and done this: https://gitlab.freedesktop.org/drm/amd/-/issues/2171#note_1727281 It turns out to get suspend to work, the `amd_pmc` module needs to be enabled (_AND_ the BIOS needs to have the "Sleep State" toggled to Windows (from Linux). I _think_ Debian should make sure amd_pmc is loaded on (all?) modern AMD laptops. I have no idea (yet) what the mechanism to make this happen is though. -- OdyX
