Control: forwarded -1 https://lore.kernel.org/all/877f41ovlu....@free-electrons.com/
Hi Ben,
On 07 Mar 2017 18:16:45 +0100 Gregory CLEMENT
<gregory.clem...@free-electrons.com> wrote:
> On lun., févr. 20 2017, Ben Hutchings <b...@decadent.org.uk> wrote:
> > On Mon, 2017-02-20 at 17:50 +0100, Thomas Petazzoni wrote:
> >> On Mon, 20 Feb 2017 16:40:25 +0000, Ben Hutchings wrote:
> >>
> >> > That is precisely what I intended. 20-23 are used by the second
> >> > Ethernet port. The old board code doesn't assign 4 or 5 at all.
> >>
> >> Then I believe it would be more explicit to have separate pin muxing
> >> configurations for SATA on this board.
> >
> > You mean, define additional pinmux nodes and override the pinctrl-0
> > property of &sata? more like this:
> >
> > --- a/arch/arm/boot/dts/kirkwood-ts419.dtsi
> > +++ b/arch/arm/boot/dts/kirkwood-ts419.dtsi
> > @@ -73,3 +73,19 @@
> > phy-handle = <ðphy1>;
> > };
> > };
> > +
> > +&pinctrl {
> > + pmx_sata0_ts419: pmx-sata0-ts419 {
> > + marvell,pins = "mpp15";
> > + marvell,function = "sata0";
> > + };
> > +
> > + pmx_sata1_ts419: pmx-sata1-ts419 {
> > + marvell,pins = "mpp16";
> > + marvell,function = "sata1";
> > + };
> > +};
> > +
> > +&sata {
> > + pinctrl-0 = <&pmx_sata0_ts419 &pmx_sata1_ts419>;
> > +};
>
> If you send a new version of your patch, then I will be able to apply
> it on mvebu/dt.
>
> Thanks,
>
> Gregory
Would it be an idea to send the updated patch for inclusion in upstream?
It's almost 6 years old, but it seems that it can still be applied cleanly.
signature.asc
Description: This is a digitally signed message part.
