$ git bisect view
commit c34db0d6b88b1da95e7ab3353e674f4f574cccee (HEAD, refs/bisect/bad)
Author: Richard Fitzgerald <r...@opensource.cirrus.com>
Date: Fri Nov 4 13:22:13 2022 +0000
ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
[ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
and used by later code that depends on the TDM settings. So
__soc_pcm_open() should not be obliterating those mask values.
The code in __soc_pcm_hw_params() uses these masks to calculate the
active channels so that only the AIF_IN/AIF_OUT widgets for the
active TDM slots are enabled. The zeroing of the masks in
__soc_pcm_open() disables this functionality so all AIF widgets
were enabled even for channels that are not assigned to a TDM slot.
Signed-off-by: Richard Fitzgerald <r...@opensource.cirrus.com>
Fixes: 2e5894d73789 ("ASoC: pcm: Add support for DAI multicodec")
Link:
https://lore.kernel.org/r/20221104132213.121847-1...@opensource.cirrus.com
Signed-off-by: Mark Brown <broo...@kernel.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
