Yes, I haven't used a machine with hid_apple in many years, but the patch sign-off is OK with me.
On Wed, Jul 21, 2021 at 10:24 AM Vincent Lefevre <vinc...@vinc17.net> wrote: > On 2021-06-02 17:24:38 +0200, Salvatore Bonaccorso wrote: > > Hi Vincent, > > > > On Wed, May 26, 2021 at 12:02:12PM +0200, Vincent Lefevre wrote: > [...] > > > I forgot that there was > > > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#35 > > > > > > from Daniel Lin, with a patch, in 2017. I've looked at this patch > > > (but have not tried it), and it adds an additional EV_MSC event > > > when hidinput_apple_event() has to generate an EV_KEY event. So > > > I confirm that should solve this issue and I'm adding the patch > > > tag (I don't know whether the patch needs an update, though). > > > > Can you, time permitting, starting from there (and needed refreshes) > > try to confirm if the patch solves the issue on top of 5.10.40? > > I could build and test the patched kernel, and I confirm that the > new patch at > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#75 > > solves the issue for me. > > > If so, next step would be to propose the change/report the bug at > > least, to upstream, get_maintainers.pl would suggest to report it > > to: > > > > Jiri Kosina <ji...@kernel.org> (maintainer:HID CORE LAYER) > > Benjamin Tissoires <benjamin.tissoi...@redhat.com> (maintainer:HID CORE > LAYER) > > linux-in...@vger.kernel.org (open list:HID CORE LAYER) > > linux-ker...@vger.kernel.org (open list) > > Since Daniel Lin (Cc'ed for any comment) is the author of the > original patch, I suppose that the patch should have: > > Co-developed-by: Daniel Lin <ephemi...@gmail.com> > Signed-off-by: Daniel Lin <ephemi...@gmail.com> > Co-developed-by: Vincent Lefevre <vinc...@vinc17.net> > Signed-off-by: Vincent Lefevre <vinc...@vinc17.net> > > as described at > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > if this is OK for him. > > -- > Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/> > 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> > Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon) >
