On Tue, Aug 22, 2017 at 2:55 AM, Ben Hutchings <b...@decadent.org.uk> wrote: > On Tue, 2017-08-22 at 01:22 +0900, Roger Shimizu wrote: > > Oh I see, that adds section (1 MiB) alignment in several places. > Surprisingly, the padding isn't completely zero-filled, so it inflates > the compressed image size too.
Good to know the details. Pushed the fix to branch master. >> Added another commit on branch rosh/check-size2, that check the >> decompressed image size. >> I confirmed it works. Please kindly review. Thank you! > > Please choose a more meaningful name than 'image2' e.g. 'uncompressed- > image'. > > For the size check, you're mostly duplicating the existing check_size() > function. It would be preferable to have a single function with some > extra parameters so that it can do both compressed and uncompressed > size checks. Thanks for your review! Pushed updated commit to branch rosh/check-uncompressed-size. Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
