On Thu, Dec 16, 2004 at 01:24:28PM +0900, Horms wrote: > On Wed, Dec 15, 2004 at 12:46:29PM +0100, Christoph Hellwig wrote: > > On Wed, Dec 15, 2004 at 11:04:40AM +0000, Martin Michlmayr wrote: > > > * Horms <[EMAIL PROTECTED]> [2004-12-15 13:28]: > > > > I checked 2.6 upstream and the refcount field is present. > > > > Curiously upstream 2.4 seems to neither include this field nor > > > > a fix for CAN-2004-0814 (N.B not CAN-2004-081 as I misquoted above). > > > > If anyone can correct me there I would be most grateful. > > > > > > Thanks for the analysis. Maybe you could contact upstream and ask why > > > it hasn't been included and also mention this compatibility problem. > > I will contact Marcello, but I am not confident of a reply.
Hi Martin, I shouldn't have been so pesemistic. I did indeed get a reply. Several in fact. http://lkml.org/lkml/2004/12/15/299 In a nutshell: 1. This patch wasn't put into 2.4.28 because it was quite intrusive and came out to late in the 2.4.28 cycle 2. It is planed for inclusion (in 2.4.29 I assume) 3. There are some updates to the patch both available and pending, I will make sure we get those, but broadly speaking the patch is unchanged. Actually, I notice that one of the uptades will most likely introduce a futher ABI change by adding "struct semaphore termios_sem;" to strut tty_struct. It would be good to get that in if we are going to increment the so number. http://lkml.org/lkml/2004/11/7/106 -- Horms