On Sat, 14 Aug 2004 13:53:36 +0200, Christoph Hellwig wrote: >> +# Upstream deletes our debian directory. Bastards. >> +sed 's#rm -rf $(objtree)/debian/#test -f $(objtree)/debian/official || rm >> -rf $(objtree)/debian/#' scripts/package/Makefile > >> scripts/package/Makefile.ouch >> +mv scripts/package/Makefile.ouch scripts/package/Makefile > > Yikes! It's bad enough we have to modify the upstream tree for firmware > removals but please don't randomly change Makefiles.
I'm not convinced we can do this through a dpatch. The problem is, dpatch must first be run on the source before we can do a proper make clean. If you've just downloaded the kernel-source package, and run a debuild on it, it will start by cleaning; this will nuke the debian subdirectory, and cause confusion/annoyance. We could just modify the Makefile in diff.gz, but then it wouldn't be overly clear that the change is necessary. I think the best solution is just to modify the orig.tar.gz, and get it accepted upstream for 2.6.9 so we don't have to resort to such things.
