Sebastiaan Couwenberg <sebas...@xs4all.nl> writes: > Hi Felix,
hi Sebastiaan, > Thanks for your changes. > > On 08/06/2016 04:35 PM, Felix Natter wrote: >> Sebastiaan Couwenberg writes: >>> Consider adding the --parallel option to dh in debian/rules to enable >>> the use of parallel builds with DEB_BUILD_OPTIONS="parallel=<N>". >> >> done. (although compilation takes less than a few seconds). > > The benefit of parallel builds for small packages is limited, adding the > --parallel option is mostly a best practice because without it debhelper > won't enable parallel support even when it's beneficial. I maintain a > couple of big packages for which you don't won't non-parallel builds as > those take several hours, instead of under an hour with > DEB_BUILD_OPTIONS="parallel=3". Yes, I agree it's best practice. > debhelper compat level 10 defaults to --parallel for all buildsystems > that support parallel building, which is a nice improvement. But compat > level 10 is not well supported in stable yet. Good to know. >>> The watch file can also be improved to handle common issues [0], like >>> the attached version for example. >> >> I added your watch file, thank you. >> So that I understand this: >> - version=3 is preferred >> - make archive type variable >> - make dversionmangle more general (backports etc.) >> - make uversionmangle more general: >> +uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha)\d*)$/$1~$2/;s/RC/rc/,\ >> --> is this best practice for github tarballs? Otherwise I think this is >> difficult because every upstream project has different terminology. >> >> --> Maybe the uscan man page should be extended regarding this? >> (it contains a github example hard-coded for tar.gz) > > Because uscan in jessie doesn't support version=4 yet, I prefer > version=3 watch files until stretch is stable. The downgrade for > svgSalamander is appreciated. Ok, thanks for the explanation. > The uversionmangle is a best practice in general, and is documented on > the wiki [0]. Because the gbp import-orig complains about uppercase RC > that is additionally translated to lowercase. > > Because the version captured in debian/watch included non-digets > (\d+\S+) you need to handle pre-releases with the uversionmangle rule, > otherwise version 1.0.0-rc1 will not precede version 1.0.0. > > [0] https://wiki.debian.org/debian/watch#Common_mistakes I'll read that page again. >>> Also consider adding upstream metadata [1]. >> >> I added this. > > I've committed a few improvements to the upstream metadata before > sponsoring the upload. Most importantly fixing the Repository URL to > include the .git suffix required for `git clone`. I've also added the > Repository-Browse field (without the .git suffix). Ok seems I was too quick copying from an existing example ;-) > I've also added a gbp.conf file to use pristine-tar by default, to not > require the --(git-)pristine-tar options for the git-buildpackage > commands. Ok, great. Many Thanks for the fixes and for sponsoring, Cheers and Best Regards, -- Felix Natter
