On 02.03.2015 21:19, Felix Natter wrote:
[...]
>> docs:
>>
>> There are some experimental Lintian warnings about duplicate
>> documentation files. Since there are only a few of them, it's not really
>> a big deal but I would examine again if there are some overlaps between
>> upstream's docs directory and the automatically created javadoc api
>> because you install both into the -doc package. Other ways for
>> deduplication are described here:
> 
> There are no overlaps between api/ and docs/, but most of the docs do
> not relate to the framework, so I think it's better to _not_ install
> docs/ at all.
> 
> --> I would put:
> - api/ AND
> - "index.html"
>   
> (http://www.knopflerfish.org/releases/current/docs/bundledoc/framework/index.html)
>  AND
> - "frameworkcommands.html"
>   
> (http://www.knopflerfish.org/releases/current/docs/bundledoc/frameworkcommands/index.html)
> 
> in the doc package (frameworkcommands/index.html is currently not
> included, but I found this here:
>   http://www.knopflerfish.org/releases/current/docs/bundledoc/index.html)
> 
> --> do you agree or shall I keep the complete docs?

I leave it to you. Include whatever you think is useful. I just wanted
to point out some options how you can get rid of duplicate files.

[...]

>> debian/copyright is complete but I would remove the trailing whitespaces.
> 
> Not sure what you mean, there were only two trailing spaces.
> Can you please check whether it's ok now?
>   https://github.com/fnatter/knopflerfish-osgi/blob/master/debian/copyright

I use the following options in Vim (~/.vimrc)

highlight ExtraWhitespace ctermbg=red guibg=red
match ExtraWhitespace /\s\+$/
autocmd BufWinEnter * match ExtraWhitespace /\s\+$/
autocmd InsertEnter * match ExtraWhitespace /\s\+\%#\@<!$/
autocmd InsertLeave * match ExtraWhitespace /\s\+$/

and

nmap ;tr :%s/\s\+$//
vmap ;tr  :s/\s\+$//

This is rather pedantic and usually not a big problem but sometimes
trailing whitespace makes it difficult to rebase patches. And with the
above options you can easily spot and remove it by pressing ;tr.

Just FYI ;-)

> --> is the structure of the package (removing all unnecessary source
> code in debian/clean-sources, ...) OK, i.e. can I migrate the changes to
> pkg-java?

Sure. I don't see a problem.

Regards,

Markus

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to