Sorry for this late reply.

On Sun, Nov 06, 2011 at 10:43:51AM +0100, Niels Thykier wrote:
> Hi,
> 
> A couple of lintian warnings worth considering to fix:
> 
> N: Processing binary package slashtime (version 0.5.13-1, arch all) ...
> [...]
> W: slashtime: old-fsf-address-in-copyright-file
> E: slashtime: description-starts-with-package-name
> I: slashtime: description-synopsis-might-not-be-phrased-properly
> W: slashtime: missing-classpath libjava-gnome-java
> W: slashtime: binary-without-manpage usr/bin/slashtime
I hope I have fixed some warnings, errors etc... My lintian did not
output all these lines + debexpo tells me that my package is lintian
clean.
 
> The run script (usr/bin/slashtime) is broken - I don't get the "cd /usr"
It is used so the application can locate icons.
Upstream contains a 'share/pixmaps' directory so the 'cd /usr' is used
so the application can locate icons in '/usr/share/pixmaps'.

> part and "exec /usr/lib/jvm/java-6-openjdk-amd64/jre/bin/java" will
> definitely not work for an arch:all package.  Furthermore I believe "$@"
> is better than $* when it comes to arguments with spaces and such (note
> the quotes on the first).
I have made a patch for that and tell the upstream author that he should
fix that upstream :)

> You may or may not be missing a short-name for the first "files"
> paragraph in d/copyright.  I don't remember my DEP-5 here, but you have
> one for the second paragraph, so I assumed you forgot it for the first one.
As far as I know the copyright file is ok and this syntax is correct
according to http://dep.debian.net/deps/dep5

I've re-uploaded the package on debexpo and also commited the new
revision of the file in the pkg-java team SVN.

Thank you for reviewing my package.

--
Guillaueme Mazoyer

Attachment: signature.asc
Description: Digital signature

Reply via email to