Le 30/03/2011 à 22:21, Niels Thykier <ni...@thykier.net> écrivit : > > I am thinking that 0~svn95 might still be a better version; you never > know what the future brings. Maybe upstream start making formal > releases if/as more people get involved in it. > Obviously we could still handle that with an epoch, so using 95 (or > 0095) as a version would not be the end of the world for us. > > [...] > > If you are "repacking" the source package anyway (which you did for the > PDF), please remove this copy as well. Since we have lost the "pristine > tar" (or rather, there never was a tarball to begin with?) we might as > well reduce the risks of compiling/using the embedded code copy (not to > mention reduce the size of the tarball). > > [...] > > I also noted a minor thing like "cd $dir && dostuff && cd $(CURDIR)". > The last cd $(CURDIR) is not necessary (every line is executed in a > separate shell). This is a feature of "make". > The dh --with maven_repo_helper can be written as "maven-repo-helper". > Personally I find the dashed version nicer to read (but this is a > "pedantic" personal preference).
Hi, I addressed your comments and uploaded the new version to mentors.d.n and to git. - URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0~svn95-1.dsc I guess we're closing in ;) Cheers, -- Nicolas Dandrimont
pgpNCZF53dwHh.pgp
Description: PGP signature
