On Mon Jul 28 20:12, Iustin Pop wrote: > Hello, > > I'm trying to package protobuf (http://code.google.com/p/protobuf/). > The source package will generate C++, Python and Java bindings. Since > I'm not knowledgeable with Java, and even less with Java packaging, > could someone please look over the Java bits?
Hi, sorry I've not had a chance to look over this until now. I've had a look at the Java bits and I have a couple of comments. > - upstream uses maven to build, but since this is not really needed > and maven resources are not available in Debian we just use a custom > ant script This works, although I've recently added javahelper to the archive which has jh_build for exactly these situations. > - openjdk-6 and the sun-jdk 5 and 6 are the only jdks that can build > the package, due the fact that the java.util.regex in classpath is > missing some functions (already implemented upstream, I think, but > not yet in sid's gcj); since openjdk works, this still allows the > package to be in main, right? Java policy is that you should pick one JDK to build with and not allow other alternatives so that you get repeatable results. Allowing alternatives to run with is fine. So you need to just depend on openjdk and change the ant wrapper to just use that. Also (speaking of dependencies), library packages shouldn't depend on JDKs, only applications which use those libraries should, so you can remove the dependencies unless you also provide a program with it. > - I'm not really sure about the naming of the (actual) jars in > /usr/share/java... right now I have protobuf-java-2.0.0beta.jar: is > the -java part needed? A few other jars in there have such a part I would say not. The rest of the Java stuff looks reasonable, although as a general point you should remove the commented out dh_ commands. I assume you'll have checked that it's pbuilder and lintian clean. Matt -- Matthew Johnson
signature.asc
Description: Digital signature
