On Sat, 21 Jun 2025 18:59, Nicolas Peugnet <[email protected]> wrote:
Hi,
On 21/06/2025 18:42, Matthias Geiger wrote:
Hi all,
[...]
Any ideas why this happens ? I'm not much of a GO expert, this
looks
like a one-off to me. Would appreciate some pointers so this can be
packaged.
I don't know if you noticed, but a previous version of this package has
been already pushed to salsa [1]. I am also interested in packaging
arduino-cli, so at one point I started working on a newer version of
this package.
Ah, nice ! obbardc (CC'd) also expressed interest in doing so. I can
help sponsoring this to NEW if you like. Personally, I already maintain
a few things, so I'd appreciate we could collaborate on this.
Let me know if you're ok with that and I can sponsor it.
IIRC these two error simply comes from omitted files in test
directories. I fixed it this way:
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,20 @@
#!/usr/bin/make -f
-export DH_GOLANG_INSTALL_EXTRA := _testdata
+# We want exclude the testdata directory from the go sources and
configure it
+# manually as it contains broken symlinks that are ignored by default by
+# dh_auto_configure.
+# We also want to remove it from the built package as it contains a binary
+# program built from the tests.
+export DH_GOLANG_EXCLUDES := testdata/
+export DH_GOLANG_EXCLUDES_ALL := 1
+
+BUILDDIR=debian/build
%:
- dh $@ --buildsystem=golang --with=golang
+ dh $@ --builddir=$(BUILDDIR) --buildsystem=golang
+
+execute_after_dh_auto_configure:
+# Manually copy the testdata directory in the builddir the following tests:
+# - TestFilterOutDirs
+# - TestReadDirRecursiveLoopDetection
+ cp -r testdata $(BUILDDIR)/src/github.com/arduino/go-paths-helper
I will push my work to the salsa repo so that you can continue based on
it if you'd like.
[1]
https://salsa.debian.org/go-team/packages/golang-github-arduino-go-paths-helper
Thanks a lot, so it was missing test data. I'll maybe have a look
tomorrow to get the package up to standard so it can enter NEW (though
this is not highly prioritzed for me).
best,
werdahias
