On Sat, Feb 1, 2025 at 7:42 PM Nicolas Peugnet <nico...@club1.fr> wrote:
> On 01/02/2025 6:05 PM, Reinhard Tartler wrote: > > On Wed, Jan 29, 2025 at 7:15 PM Nicolas Peugnet <nico...@club1.fr> > wrote: > >> Thank you for the pointers. Indeed in the case of packages from > >> "docker/cli" and "docker/docker" it is just a matter of adding them to > >> the golang-github-docker-docker-dev.install file. But in the case of > >> "moby/buildkit", some of the packages are not present in the current > >> source packages, as they are there as part of the engine's vendor > >> directory, which is incomplete. > > > > Cool, if these packages are easy to add and enable, let's start with > that. > > Can you send me a MR? > > Yes, these were the two MRs that you merged just now. > > >> So I figured "moby/buildkit" should really be fully packaged. I started > >> to do this in > >> > >> > https://salsa.debian.org/go-team/packages/golang-github-moby-buildkit/-/tree/debian/sid > >> . > >> > >> With a few patches [1] to disable some features dependent on some > >> missing packages, the number of missing dependencies is only 3 [2] > >> (golang-github-spdx-tools-golang is in NEW). > > > > Awesome, thanks! > > > >> Then I realized that the docker.io package is in fact a "Multiple > >> Upstream Tarballs" package, and as the cli, engine and buildkit are all > >> inter-dependent of each other, I think it would probably be better to > >> add "moby/buildkit" in the docker.io source package. > > So about this, what do you think? For now, I will continue to work on > the separated package for "moby/buildkit", but wouldn't it be better if > it were part of the docker.io package? > I took a look at the docker.io package, to refresh my recollection on the topic of dependencies, and I think I agree with you. If I understand things correctly, we currently get away with that by keeping "buildkit" in the "vendor/" directory. You are suggesting to promote that dependency as part of the MUT upload. That sounds reasonable. Can you work on a MR to modify the docker.io package to incorporate this new tarball? -- regards, Reinhard
