Mathias Gibbens <gib...@debian.org> writes:

> On Fri, 2024-11-29 at 12:05 +0100, Simon Josefsson wrote:
>> Thanks!  Alas minio-pkg doesn't build with go-jwx v2:
>> 
>> [snip]
>> 
>> The only reverse dependency is golang-github-minio-colorjson, and that
>> package happens to build with minio-pkg without pkg/licverifier and
>> pkg/env/web_env... so we can simply patch away the dependency on go-jwx
>> in minio-pkg.  Thoughts?  I think this is an acceptable path forward.
>
>   Thanks for going ahead and uploading newer versions of go-jwx and
> minio-pkg!
>
>   Unfortunately minio-client (on my ITP list) depends on those
> libraries that got patched away. ☹️ I spent some time this afternoon
> working through the actual code changes needed for minio-pkg to
> properly build with go-jwx v2, and thanks to some good upstream
> documentation it turned out to be fairly straightforward. I'll do an
> upload of the updated minio-pkg with those changes in a little bit.
>
>> I have opened an upstream pull request to update it to v2 but no
>> response:
>> 
>> https://github.com/minio/pkg/pull/139
>
>   I've posted a comment there with the proposed changes. Feel free to
> pull them into your branch for the PR, and hopefully upstream will be
> willing to incorporate the changes.

Thank you for quick attention and upstream patch, and sorry for stomping
on your package.  I added your patch to the upstream pull request, and
I'm happy to see the package restored in functionality.

/Simon

Attachment: signature.asc
Description: PGP signature

Reply via email to