> > If any of you have have spare time, I'd appreciate a review of > > https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-pflag > > before I upload. > > Looks good to me. > > Instead of the patch I would have added in debian/rules: > > override_dh_auto_install: > dh_auto_install -- --no-binaries
Good idea, this works as well. However I was planning to submit the patch upstream. Do you agree it would be a good fix upstream to not build any example binaries unless the build is instructed to do so with go build --tags=test or something? > I would have added the following at the end of > golang-github-muesli-mango-pflag-dev's Description: > > . > This package contains the Go development library. Updated accordingly. > But these are subjective nit-picks, but I wanted to mention it for your > consideration. I am glad to get nit-picks so that I get into the correct Go team habits and ways of packaging right away.
