On Fri, 2023-08-04 at 11:25 +0000, Mathias Gibbens wrote: > On Fri, 2023-08-04 at 12:58 +0800, Shengjing Zhu wrote: > > > > I didn't see lxd imports github.com/uber/jaeger-client-go. Did I > > miss something? > > The dependency tree looks like this: > > LXD > github.com/grafana/dskit (ITP #1001989) > github.com/weaveworks/common (ITP #1001982) > github.com/uber/jaeger-client-go
dskit has since dropped its dependency on weaveworks/common, and there is work to also migrate away from jaeger-client-go. For the time being I've packaged jaeger-client-go with the vendored copy of thrift, and documented why it can't easily be removed or worth the effort of updating everything to the latest version of thrift. We'll see what ftpmaster says when they review it. Mathias >
signature.asc
Description: This is a digitally signed message part
