Hi Jongmin,

On 09/09/2023 04:36, Jongmin Kim wrote:
Hi Arun Kumar Pariyar,

Many thanks for your careful review.

On Sat, 9 Sept 2023 at 03:25, Arun Kumar Pariyar <a...@debian.org> wrote:
I went through your package and I suggest you to fix some of the issues below.

* Add debian/upstream/metadata.

Now added, to all my RFSes.

* Remove plumbing/format/packfile/.packfile_test.go.swp and repack your source.

My mistake. Now removed. Many thanks!

* Update debian/copyright information for plumbing/format/index/match.go
    as the code is mostly copied from golang src. [1]

Added the missing copyright information.

* Also, you may want to consider applying `wrap-and-sort`.

Now applied, to all my RFSes.

Could you please review again? Thanks!


Uploaded to NEW.

dput ftp-master 
../golang-github-jesseduffield-go-git_5.1.2+git20221018.fdd53fe-1_amd64.changes
D: Setting host argument.
Checking signature on .changes
gpg: 
../golang-github-jesseduffield-go-git_5.1.2+git20221018.fdd53fe-1_amd64.changes:
 Valid signature from 4B542AF704F74516
Checking signature on .dsc
gpg: ../golang-github-jesseduffield-go-git_5.1.2+git20221018.fdd53fe-1.dsc: 
Valid signature from 4B542AF704F74516
Uploading to ftp-master (via ftp to ftp.upload.debian.org):
  Uploading golang-github-jesseduffield-go-git_5.1.2+git20221018.fdd53fe-1.dsc: 
done.
  Uploading 
golang-github-jesseduffield-go-git_5.1.2+git20221018.fdd53fe.orig.tar.gz: done.
  Uploading 
golang-github-jesseduffield-go-git_5.1.2+git20221018.fdd53fe-1.debian.tar.xz: 
done.
  Uploading 
golang-github-jesseduffield-go-git-dev_5.1.2+git20221018.fdd53fe-1_all.deb: 
done.
  Uploading 
golang-github-jesseduffield-go-git_5.1.2+git20221018.fdd53fe-1_amd64.buildinfo: 
done.
  Uploading 
golang-github-jesseduffield-go-git_5.1.2+git20221018.fdd53fe-1_amd64.changes: 
done.
Successfully uploaded packages.

Thanks for your contribution!

Regards,
~ Arun Kumar Pariyar

Attachment: OpenPGP_0x4B542AF704F74516.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to