debian/control
pykml is a better name for the binary package
See for example:
https://salsa.debian.org/debian-gis-team/python-stetl/-/blob/master/debian/control#L56
`apt install pykml` gets you the executables and library which is more
intuitive than `apt install pykml-bin`.
debian/rules
Why did you remove PYBUILD_NAME?
Kind Regards,
Bas
On 5/18/22 07:55, Antonio Valentino wrote:
Dear Bas,
all the requested changes should be now implemented.
Please feel free to go on with your review.
kind regards
antonio
Il 16/05/22 08:43, Antonio Valentino ha scritto:
Dear Bas,
Il 15/05/22 18:46, Sebastiaan Couwenberg ha scritto:
On 5/15/22 11:07, Antonio Valentino wrote:
Please feel free to review them.
debian/copyright
GitHub repo is better than PyPI for Source.
debian/patches/*
Forward patches upstream and mark them accordingly.
Don't use a mailinglist for From/Author.
debian/python3-pykml.lintian-overrides
Move executables to pykml binary package.
debian/watch
Using GitHub tags is generally better than the PyPI service. PyPI is
only for cases where there are not tagged releases elsewhere.
But the GitHub repo lacks tags for the releases on PyPI. And the
project hasn't seen any changes in 10 years. Doesn't look like a good
project to have in Debian. You'll have to carry a lot of patches that
upstream won't act on.
OK, I think that I have addressed most of the points.
Only the split out of executable scripts into a dedicated package is
missing.
I will implement it later today or tomorrow.
kind regards
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
