Package: libffi-dev
Version: 3.4.6-1
Severity: minor
Tags: patch
* What led up to the situation?
Checking for defects with a new version
test-[g|n]roff -mandoc -t -K utf8 -rF0 -rHY=0 -rCHECKSTYLE=10 -ww -z < "man
page"
[Use "groff -e ' $' -e '\\~$' <file>" to find obvious trailing spaces.]
["test-groff" is a script in the repository for "groff"; is not shipped]
(local copy and "troff" slightly changed by me).
[The fate of "test-nroff" was decided in groff bug #55941.]
* What was the outcome of this action?
troff:<stdin>:25: warning: trailing space in the line
* What outcome did you expect instead?
No output (no warnings).
-.-
General remarks and further material, if a diff-file exist, are in the
attachments.
-- System Information:
Debian Release: trixie/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 6.12.10-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=is_IS.iso88591, LC_CTYPE=is_IS.iso88591 (charmap=ISO-8859-1),
LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)
Versions of packages libffi-dev depends on:
ii libffi8 3.4.6-1
libffi-dev recommends no packages.
libffi-dev suggests no packages.
-- no debconf information
Input file is ffi_prep_cif.3
Output from "mandoc -T lint ffi_prep_cif.3": (shortened list)
1 : ffi_prep_cif.3: WARNING: missing Os macro, using ""
3 new sentence, new line
2 whitespace at end of input line
-.-.
Output from "test-groff -mandoc -t -ww -z ffi_prep_cif.3": (shortened list)
1 trailing space in the line
-.-.
Remove space characters (whitespace) at the end of lines.
Use "git apply ... --whitespace=fix" to fix extra space issues, or use
global configuration "core.whitespace".
Number of lines affected is
2
-.-.
Wrong distance between sentences in the input file.
Separate the sentences and subordinate clauses; each begins on a new
line. See man-pages(7) ("Conventions for source file layout") and
"info groff" ("Input Conventions").
The best procedure is to always start a new sentence on a new line,
at least, if you are typing on a computer.
Remember coding: Only one command ("sentence") on each (logical) line.
E-mail: Easier to quote exactly the relevant lines.
Generally: Easier to edit the sentence.
Patches: Less unaffected text.
Search for two adjacent words is easier, when they belong to the same line,
and the same phrase.
The amount of space between sentences in the output can then be
controlled with the ".ss" request.
Mark a final abbreviation point as such by suffixing it with "\&".
40:return value. Note that to call a variadic function
58:is malformed. If
62:will be returned. Available ABIs are
-.-.
Output from "test-groff -mandoc -t -K utf8 -rF0 -rHY=0 -rCHECKSTYLE=10 -ww -z
":
troff:<stdin>:25: warning: trailing space in the line
--- ffi_prep_cif.3 2025-01-31 02:15:03.297942762 +0000
+++ ffi_prep_cif.3.new 2025-01-31 02:21:42.939407370 +0000
@@ -5,7 +5,7 @@
.Nd Prepare a
.Nm ffi_cif
structure for use with
-.Nm ffi_call
+.Nm ffi_call
.
.Sh SYNOPSIS
.In ffi.h
@@ -22,7 +22,7 @@ The
.Nm ffi_prep_cif
function prepares a
.Nm ffi_cif
-structure for use with
+structure for use with
.Nm ffi_call
.
.Fa abi
@@ -32,12 +32,14 @@ is an array of
.Fa nargs
pointers to
.Nm ffi_type
-structs that describe the data type, size and alignment of each argument.
+structs that describe the data type,
+size and alignment of each argument.
.Fa rtype
points to an
.Nm ffi_type
-that describes the data type, size and alignment of the
-return value. Note that to call a variadic function
+that describes the data type,
+size and alignment of the return value.
+Note that to call a variadic function
.Nm ffi_prep_cif_var
must be used instead.
.Sh RETURN VALUES
@@ -55,12 +57,13 @@ or
.Fa atypes
or
.Fa rtype
-is malformed. If
+is malformed.
+If
.Fa abi
does not refer to a valid ABI,
.Nm FFI_BAD_ABI
-will be returned. Available ABIs are
-defined in
+will be returned.
+Available ABIs are defined in
.Nm <ffitarget.h> .
.Sh SEE ALSO
.Xr ffi 3 ,
Any program (person), that produces man pages, should check the output
for defects by using (both groff and nroff)
[gn]roff -mandoc -t -ww -b -z -K utf8 <man page>
The same goes for man pages that are used as an input.
For a style guide use
mandoc -T lint
-.-
Any "autogenerator" should check its products with the above mentioned
'groff', 'mandoc', and additionally with 'nroff ...'.
It should also check its input files for too long (> 80) lines.
This is just a simple quality control measure.
The "autogenerator" may have to be corrected to get a better man page,
the source file may, and any additional file may.
Common defects:
Not removing trailing spaces (in in- and output).
The reason for these trailing spaces should be found and eliminated.
Not beginning each input sentence on a new line.
Line length should thus be reduced.
The script "reportbug" uses 'quoted-printable' encoding when a line is
longer than 1024 characters in an 'ascii' file.
See man-pages(7), item "semantic newline".
-.-
The difference between the formatted output of the original and patched file
can be seen with:
nroff -mandoc <file1> > <out1>
nroff -mandoc <file2> > <out2>
diff -u <out1> <out2>
and for groff, using
\"printf '%s\n%s\n' '.kern 0' '.ss 12 0' | groff -mandoc -Z - \"
instead of 'nroff -mandoc'
Add the option '-t', if the file contains a table.
Read the output from 'diff -u ...' with 'less -R' or similar.
-.-.
If 'man' (man-db) is used to check the manual for warnings,
the following must be set:
The option \"-warnings=w\"
The environmental variable:
export MAN_KEEP_STDERR=yes (or any non-empty value)
or
(produce only warnings):
export MANROFFOPT=\"-ww -b -z\"
export MAN_KEEP_STDERR=yes (or any non-empty value)
-.-
