On Wed, 2014-03-05 at 22:27:21 +0100, Guillem Jover wrote: > On Wed, 2014-03-05 at 20:01:29 +0100, Stefano Zacchiroli wrote: > > There seems to be at least two other failure causes: > > > > - patches not applying cleanly, e.g.: > > > > dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -g0 -b -z > > .dpkg-orig < ./rx_1.5-6.diff.gz gave error exit status 1 > > can't find file to patch at input line 3 > > > > (from > > http://people.debian.org/~zack/dpkg-source-x-regression/unextractable-dsc/2.2-potato/rx_1.5-6.dsc.log) > > I'm checking when this regressed.
Ok, this is due to the fuzz level (-F 0), but strictly speaking this never regressed in dpkg-source, as it has used that option since its introduction in dpkg 1.3.0 (pre-rex Debian 1.2). <http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=commit;h=a9fe21f068524faa2e32a76c412a29371bba08da> I'm just guessing those sources where created and extracted manually, probably around the time when the “new source format” got introduced, and where maintainers might have not switched to the new tools yet. <http://archive.debian.org/debian/dists/Debian-1.2/main/source/README.source-unpack> I'm a bit wary of adding a force option, even if only for format 1.0, to allow something that was never allowed in the first place, also taking into account there's source packages in ancient releases that are in the old format that dpkg-source does not know either. Given the above, in principle I'm tending towards not adding such an option to allow wrong fuzz, but I'll still ponder about this one for a bit. Guillem -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
