Hi Otto,

thanks for writing the two most comprehensive docs about packaging, git and gbp I have read in the last years. I even tried writing some. Will stop doing that now that your docs exist. Impressive work.

I have some comments though.

On Wed, May 28, 2025 at 06:36:00AM -0700, Otto Kekäläinen wrote:
I feel that my own blog is the
best place to write of what I would *choose* as the optimal workflow
for myself and what I teach to those I mentor who are just starting
their learning journey and can't cope with too many options,

I would suggest mentioning in your documents that they represent your personal opinion and that people who want to delve into alternatives could read the official docs here, here and here.

in
particular these two:

- https://optimizedbyotto.com/post/debian-packaging-from-git/

I would love this article (or a third one) explaining how to convert an already existing package that was created using more conventional workflows to a form that preserves at least the upstream git history from the conversion point on. I guess that aligning the newly imported upstream master branch and the existing upstream/latest branch needs some serious git magic that is beyond what I can do.

We encourage our new maintainers to take over orphaned and/or existing packages so they should learn how to do that properly.

I especially like the idea to work through MRs even in one's own repository to allow for third-party reviews.

does it make sense to work in debian/latest and only last before pushing for review create another branch next/debian/latest? I'd always intuitively work in next/debian/latest directly.

Regarding Upstream MR/PRs, can I really directly push to a github repository that I am not affiliated with to open a PR? Or did you omit the fork/another remote part of the process here?

As far as I know, unfortunately gbp pq import/export need a clean directory with all changes committed. The document claims that gbp pq import/export can be run "at any time".

My personal pet peeve is the difference between the source package and the packaging git repository contents. Those two especially differ in the state of patches: They're applied in the unpacked source package, and not applied in the packed source package and in the git repository contents. That is for me a constant source of confusion and it would be nice if your document would contain an explanation.

- https://optimizedbyotto.com/post/debian-source-package-git/

It hurts me a bit to read that Ubuntu is more famous than Debian. We're doing the majority of the work.

Some of the command lines that repeat between the two documents vary. I am sure that both ways work, but if the variation is not absolutely needed, it shouldnt be there.

I have tried my best to make them relatively short, concrete and
illustrative with diagrams etc.

This is among the best documentation I have ever read in Debian. Thank you very much, and I hope that you can make good use of my feedback.

Greetings
Marc

--
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany    |  lose things."    Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421

Reply via email to