Hi! ... > > - The number of contributors/maintainers is low everywhere. Ending > > single-person maintainership is not going to happen any soon, but hopefully, > > we can work towards first increasing the pool of contributors who > > participate, and then expand on practices around Merge Requests and reviews > > and maybe have some kind of formal sign-offs from at least two people before > > upload. Initially, perhaps only for the top-150 packages. But before we can > > institute review workflows, we need to have more unification around the > > version control and basic packaging workflows. > > I'm still dubious any "2 people sign-off" can work [1]. In your > investigations, > did you find other distributions which implemented this successfully? > > I think "work towards easier collaboration" and "require more than one person > for every commit/upload" are two very different things which should be > discussed independently. > > Thanks! > > cheers, josch > > [1] My own experience with this comes from my contributions to devscripts > which > is in the debian group, thus "team" maintained and probably all of you have it > installed and should feel responsible for it (right?). Nevertheless, my MRs > mostly get zero replies, so I usually just merge them after waiting a couple > of > months. The situation is a bit better for sbuild but not by much.
I see you have 41 MRs at https://salsa.debian.org/debian/devscripts/-/merge_requests?scope=all&state=all&author_username=josch Some of them were approved by Niels, but indeed most go without approval nor even comments. I Salsa CI and in Lintian for example I do see pretty good review activity. Perhaps we just need to have more visibility and reminders for people to check out https://salsa.debian.org/debian/devscripts/-/merge_requests or even https://salsa.debian.org/groups/debian/-/merge_requests which has now 993 MRs open (and nearly 10k MRs in total). I wonder if it would make sense to organize some kind of "office hours" for code reviews and code testing best practices and guidance...