On Mon, Jan 20, 2020 at 01:40:29AM +0000, Paul Wise wrote: > On Sun, Jan 19, 2020 at 9:42 AM Timo Bingmann wrote: > > > I wonder if it would be possible to package and include two simple but > > extremely useful command line programs in Debian? I wrote them 10 years > > and 7 years ago; they have stood the test of time and remain useful. > > As an upstream maintainer you may want to look at our guide: > > https://wiki.debian.org/UpstreamGuide > > > disk-filltest - A Simple Tool to Detect Bad Disks by Filling with Random > > Data > > https://panthema.net/2013/disk-filltest/
A comment (NOT a "why do we need this when we have the other thing):
have you looked at the fio tool? Yes, I know that there are many reasons
why one would have written a much simpler version of a tool, possibly
even many years earlier, and there are reasons why one would want to
keep using their version even years later (I have my own share of
these), but just making sure that you are aware of some alternatives.
That said, *thanks* for your desire to make Debian better by including
more useful tools!
[snip]
>
> I noticed you pass -O3 to the compiler by default, I think I would
> leave it to the distributor to set that, something like this:
>
> CFLAGS += -W -Wall -ansi
Just as an idea: if you're comfortable with a Makefile that makes use of
slight extensions to the POSIX syntax such as += and ?=, I usually do
something like:
CC?= cc
CPPFLAGS_STD?= -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700
CPPFLAGS+= ${CPPFLAGS_STD}
CFLAGS_OPT?= -O2 -g -pipe
CFLAGS_STD?= -std=c99
CFLAGS_WARN?= -Wall -W -Wextra
CFLAGS?= ${CFLAGS_OPT}
CFLAGS+= ${CFLAGS_STD} ${CFLAGS_WARN}
Sure, that's not two lines, but it is a sensible (at least for me)
compromise between flexibility (allow the downstream packagers to easily
modify the flags) and policy (add a couple of flags in 99% of the
builds, unless the downstream packager or the user doing a manual build
has explicitly specified more than one variable on the make command
line).
G'luck,
Peter
--
Peter Pentchev roam@{ringlet.net,debian.org,FreeBSD.org} p...@storpool.com
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
signature.asc
Description: PGP signature
