Shachar Shemesh <shac...@debian.org> writes:
> On 26/01/11 13:03, Goswin von Brederlow wrote:
>>
>> Some things I noticed:
>>
>> safewrite.h:
>> - missing headers, e.g. for mode_t
>>
> No. That's intentional. I'm assuming the people who will use
> safewrite.h are going to RTFM, where it clearly says that those
> includes are needed. I might reconsider if valid reasons are provided,
> but I would like to avoid keep including the same headers over and
> over.
I absolutely hate that. A header file should be compilable on its
own. The times when #include <foo.h> would slow down the compiler are
long gone and all include files are protected with #ifndef NAME so
duplicate includes are harmless.
On the other hand finding out what include files to include and in what
order is a real pain if you have multiple files. Even if you have read
the manual you will have to reread it every time you start a new project
again and again to get that right.
>> - no 'extern "C" {'
>>
> You are right. Fixed now.
>>
>> I don't like how your functions are destructive to the path argument.
> I don't think that is a major issue, but I do think that the reliance
> on PATH_MAX is. I think the current implementation solves both of
> these concerns.
>
> Shachar
Well, PATH_MAX breaks on hurd iirc so that is (or was) a reall show stopped.
MfG
Goswin
--
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87ei7lt8u9.fsf@frosties.localnet
