Bug#393970: chiark-tcl - FTBFS: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'

[Christoph Berg]

Re: Brice Goglin 2007-01-09 <[EMAIL PROTECTED]>
> %zu is available to printf size_t, patch below.

Hi,

here's the NMU diff for the NMU I'll upload to delayed/7.

debdiff chiark-tcl_1.0.1.dsc /srv/pbuilder/result/chiark-tcl_1.0.1.1.dsc
 cdb/writeable.c  |    2 +-
 debian/changelog |    8 ++++++++
 hbytes/ulongs.c  |    1 -
 3 files changed, 9 insertions(+), 2 deletions(-)

dpkg-source: warning: extracting unsigned source package 
(/srv/pbuilder/result/chiark-tcl_1.0.1.1.dsc)
diff -Nru /home/cb/tmp/5dGJeIl1h6/chiark-tcl-1.0.1/cdb/writeable.c 
/home/cb/tmp/bF7UzGMUAV/chiark-tcl-1.0.1.1/cdb/writeable.c
--- /home/cb/tmp/5dGJeIl1h6/chiark-tcl-1.0.1/cdb/writeable.c    2006-08-25 
23:04:33.000000000 +0200
+++ /home/cb/tmp/bF7UzGMUAV/chiark-tcl-1.0.1.1/cdb/writeable.c  2007-01-09 
03:33:45.000000000 +0100
@@ -313,7 +313,7 @@
 static int writerecord(FILE *f, const char *key, const HashValue *val) {
   int r;
 
-  r= fprintf(f, "+%d,%d:%s->", strlen(key), val->len, key);
+  r= fprintf(f, "+%zu,%d:%s->", strlen(key), val->len, key);
   if (r<0) return -1;
   
   r= fwrite(val->data, 1, val->len, f);
diff -Nru /home/cb/tmp/5dGJeIl1h6/chiark-tcl-1.0.1/debian/changelog 
/home/cb/tmp/bF7UzGMUAV/chiark-tcl-1.0.1.1/debian/changelog
--- /home/cb/tmp/5dGJeIl1h6/chiark-tcl-1.0.1/debian/changelog   2006-10-18 
18:05:42.000000000 +0200
+++ /home/cb/tmp/bF7UzGMUAV/chiark-tcl-1.0.1.1/debian/changelog 2007-01-12 
01:10:11.000000000 +0100
@@ -1,3 +1,11 @@
+chiark-tcl (1.0.1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix a printf format for size_t, closes: #393970.
+  * Drop a useless assert causing a "comparison always true", closes: #394039.
+
+ -- Brice Goglin <[EMAIL PROTECTED]>  Fri, 12 Jan 2007 01:10:04 +0100
+
 chiark-tcl (1.0.1) unstable; urgency=low
 
   New features:
diff -Nru /home/cb/tmp/5dGJeIl1h6/chiark-tcl-1.0.1/hbytes/ulongs.c 
/home/cb/tmp/bF7UzGMUAV/chiark-tcl-1.0.1.1/hbytes/ulongs.c
--- /home/cb/tmp/5dGJeIl1h6/chiark-tcl-1.0.1/hbytes/ulongs.c    2006-03-30 
21:11:24.000000000 +0200
+++ /home/cb/tmp/bF7UzGMUAV/chiark-tcl-1.0.1.1/hbytes/ulongs.c  2007-01-09 
03:30:12.000000000 +0100
@@ -282,7 +282,6 @@
 
   val= *(const uint32_t*)&o->internalRep.longValue;
 
-  assert(val <= 0xffffffffUL);
   snprintf(buf,sizeof(buf), "%08lx", (unsigned long)val);
 
   cht_obj_updatestr_vstringls(o, buf, sizeof(buf)-1, (char*)0);

Christoph
-- 
[EMAIL PROTECTED] | http://www.df7cb.de/

signature.asc
Description: Digital signature