tags 396043 + patch
thanks
Ok, got it....
gnome-hearts crashes when it's not able to find the configured cards
style, since no card style gets activated!
The default "bonded.png" style doesn't seem to be available in the
package. This should probably be fixed as well, so the default
configuration is sensible. (Eigther by adding it, or by using another
default.)
Incorrectly configured styles should probably give a warning and
possibly force the user to chose another one.... I'll leave that up to
someone else to implement.
The attached patch is the most simple workaround I could think of.
Always activate the first available style to make sure one is active.
(selected style will then override if there is a valid configuration
found while loading the other available styles.)
(This means: if there are _no_ styles available the application will
still crash, but atleast it won't crash as soon as it's incorrectly
configured...)
Regards,
Andreas Henriksson
diff -urip gnome-hearts-0.1.2.orig/src/hearts.c gnome-hearts-0.1.2/src/hearts.c
--- gnome-hearts-0.1.2.orig/src/hearts.c 2006-08-03 23:28:02.000000000 +0200
+++ gnome-hearts-0.1.2/src/hearts.c 2006-10-29 23:34:19.000000000 +0100
@@ -621,7 +621,8 @@ void card_style_add(gpointer key, gpoint
gtk_combo_box_append_text(card_style_box, (gchar*)key);
- if (strcmp(game_card_style->str, (gchar*)key) == 0)
+ if ((strcmp(game_card_style->str, (gchar*)key) == 0)
+ || (cards_image == NULL))
{
gtk_combo_box_set_active(card_style_box, i);
cards_image = cards_image_from_file(value);
