Control: tags -1 patch Hi,
On Wed, Aug 27, 2025 at 06:52:57PM +0200, Aurelien Jarno wrote:
Hi,
[...]
> are having on either -3 *or* -1. For what it's worth, both gcc-12 > version 12.4.0-8 and 12.5.0-1 were uploaded since the last successful > buildd build of src:golang-1.24, so it's possible one of those is > related too (the source of libtsan and the error message we're seeing > in the tests). > indeed. Very high probability is libtsan2_15.2.0-1 maybe...Yep, I confirm that. The issue is reproducible in a trixie environment with only gcc-15-base and libtsan2 from forky. Building golang-1.24 with gcc-15 doesn't fix the issue, so it's not due to the version mismatch between the compiler and library. It rather seems to be a new feature or bug in libtsan2.
I proposed the workaround to skip tsan tests on riscv64 explicitly in case block something. Certainly, I am thinking that how to report this to upstream. Tested it on Unmatched already, please have a review in your free time. -- Regards, -- Bo YU
diff -Nru golang-1.24-1.24.4/debian/changelog golang-1.24-1.24.4/debian/changelog --- golang-1.24-1.24.4/debian/changelog 2025-08-19 13:22:03.000000000 +0800 +++ golang-1.24-1.24.4/debian/changelog 2025-08-30 12:38:28.000000000 +0800 @@ -1,3 +1,10 @@ +golang-1.24 (1.24.4-3.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * workaround to skip tsan test on riscv64. (Closes: #1112166) + + -- Bo YU <[email protected]> Sat, 30 Aug 2025 12:38:28 +0800 + golang-1.24 (1.24.4-3) unstable; urgency=medium * Set better CC defaults around arm* (native for arm*, armhf for others) diff -Nru golang-1.24-1.24.4/debian/patches/0003-Skip-flasky-TestAsan-on-riscv64.patch golang-1.24-1.24.4/debian/patches/0003-Skip-flasky-TestAsan-on-riscv64.patch --- golang-1.24-1.24.4/debian/patches/0003-Skip-flasky-TestAsan-on-riscv64.patch 1970-01-01 08:00:00.000000000 +0800 +++ golang-1.24-1.24.4/debian/patches/0003-Skip-flasky-TestAsan-on-riscv64.patch 2025-08-30 12:38:28.000000000 +0800 @@ -0,0 +1,51 @@ +Description: skip tsan test on riscv64 + Race detector on riscv64 is not support yet, this is usually no problem on Debian + building because it will be skipped automatically. But others package updated + recently lead to the test failed. +Author: Bo YU <[email protected]> +Origin: upstream, https://github.com/golang/go/issues/64345 +Bug: https://bugs.debian.org/1112166 +Last-Update: 2025-08-30 +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +--- a/src/cmd/cgo/internal/testsanitizers/tsan_test.go ++++ b/src/cmd/cgo/internal/testsanitizers/tsan_test.go +@@ -11,6 +11,7 @@ + "os/exec" + "strings" + "testing" ++ "runtime" + ) + + func TestTSAN(t *testing.T) { +@@ -29,6 +30,10 @@ + if !compilerRequiredTsanVersion(goos, goarch) { + t.Skipf("skipping on %s/%s; compiler version for -tsan option is too old.", goos, goarch) + } ++ if runtime.GOARCH == "riscv64" { ++ t.Skipf("skipping; flaky on %s", runtime.GOARCH) ++ } ++ + + t.Parallel() + requireOvercommit(t) +--- a/src/cmd/cgo/internal/testsanitizers/cshared_test.go ++++ b/src/cmd/cgo/internal/testsanitizers/cshared_test.go +@@ -14,6 +14,7 @@ + "os/exec" + "strings" + "testing" ++ "runtime" + ) + + func TestShared(t *testing.T) { +@@ -65,6 +66,9 @@ + t.Logf("skipping %s test on %s/%s; compiler version too old for -tsan.", name, GOOS, GOARCH) + continue + } ++ if runtime.GOARCH == "riscv64" { ++ t.Skipf("skipping; flaky on %s", runtime.GOARCH) ++ } + + t.Run(name, func(t *testing.T) { + t.Parallel() diff -Nru golang-1.24-1.24.4/debian/patches/series golang-1.24-1.24.4/debian/patches/series --- golang-1.24-1.24.4/debian/patches/series 2025-08-08 10:26:49.000000000 +0800 +++ golang-1.24-1.24.4/debian/patches/series 2025-08-30 12:38:28.000000000 +0800 @@ -1,2 +1,3 @@ 0001-Skip-flaky-TestCrashDumpsAllThreads-on-mips64le.patch 0002-Skip-flaky-TestCrashDumpsAllThreads-on-s390x.patch +0003-Skip-flasky-TestAsan-on-riscv64.patch
signature.asc
Description: PGP signature
