Hi,
On Tue, 15 Jul 2025, at 09:54, Paul Gevers wrote:
> On 13-07-2025 17:35, Andrej Shadura wrote:
>> This is, obviously, not going to work, as bmake doesn’t support *any* long
>> (dash-dash) options, and does not support job servers at all. Which means
>> the debhelper integration module has to filter out all long options out of
>> MAKEFLAGS:
>>
>> @@ -56,6 +56,10 @@ sub do_make {
>> if ($ENV{MAKEFLAGS} =~ /^[^-]/) {
>> $ENV{MAKEFLAGS} = "-$ENV{MAKEFLAGS}";
>> }
>> + my @makeflags = grep {
>> + !/^--/
>> + } split(' ', $ENV{MAKEFLAGS});
>> + $ENV{MAKEFLAGS} = join(' ', @makeflags);
>> }
> I understand that users of bmake shouldn't (and wouldn't) pass long
> options to bmake, but stripping them out blindly (without warning)
> sounds like it could lead to surprises. I understand that these options
> come from toolchain things around bmake, so wouldn't it be smarter to
> specifically filter those out and/or emit a warning when you strip an
> unrecognized option?
That is correct, but this would not be a regression since bmake would already
fail on these long options in unexpected ways (e.g. interpreting them as a
negative job number etc).
I will rework this filtering in the next release though, thanks for the idea.
--
Cheers,
Andrej
