Package: wine Version: 9.0~repack-7 Severity: grave Justification: renders package unusable X-Debbugs-Cc: debian-...@lists.debian.org, mar...@martin.st User: debian-...@lists.debian.org Usertags: arm64
Dear Maintainer, When starting Wine (9.0~repack-7) on Debian Trixie, e.g. with a simple command like "wine wineboot", it hangs. The issue is caused by the Debian packaging. Upstream Wine errors out if you don't have Clang available while building it, while the Debian packaging has edited away this configure check - see https://salsa.debian.org/wine-team/wine/-/blob/debian13-wine09/debian/patches/arm/gcc.patch. Editing away the check may have seemed to have worked when it was first done (in https://salsa.debian.org/wine-team/wine/-/commit/2c3ae8a186f255958da213fe35510908d9ca50ca for Wine 7.0), but for the current Wine versions, this no longer results in a functioning build of Wine. Initially, compiling wine for arm64 with GCC would error out at configure time, due to `__builtin_ms_va_list` not being supported - see https://gitlab.winehq.org/wine/wine/-/blob/wine-5.0/configure.ac?ref_type=tags#L211-216. If this configure check was removed/bypassed, compiling would still fail for the exact same reason. However this changed in https://gitlab.winehq.org/wine/wine/-/commit/dac1e16dd4edc8404c59dc63ae708cd8bb50a38a (since Wine 6.0-rc4). This made the use of `__builtin_ms_va_list` and `__builtin_ms_va_start` etc optional on the code level. This was not intended to make it possible to build Wine with a compiler that doesn't support them; the assumption was still that configure disallows such build configurations. The reason for the change was that the Wine headers are also included when building the widl tool, which is used as part of mingw-w64-tools; this allowed building the widl tool on Linux/aarch64 with GCC. But if the configure check was bypassed, building still succeeded, but you'd get a build of Wine that uses the wrong ABI for varargs. This is the case of the Wine 7.0 and 8.0 builds in Debian bullseye-backports and bookworm. They roughly seem to work, but if executing any code with varargs (e.g. any nontrivial use of printf), it crashes. Further along, in https://gitlab.winehq.org/wine/wine/-/commit/11486a7b48aa43421ada5a557d892feabf27b372 (since Wine 7.4), the configure check was changed from requiring `__builtin_ms_va_list` to explicitly requiring a PE cross compiler. Bypassing this check also still mostly seemed benign at the time (Wine 8.0 in Debian bookworm also mostly seems to work, but also has incorrect handling of varargs), but at some point later, the code probably strictly started assuming that arm64 builds have the userland DLLs built as PE, not ELF. Thus since Wine 9.0, it simply hangs on startup when the requirement for a PE cross compiler has been bypassed. Applying a change like this produces a working build of Wine 9.0: ``` diff --git a/debian/control.in b/debian/control.in index cbe264ca228..46ffe53d824 100644 --- a/debian/control.in +++ b/debian/control.in @@ -12,6 +12,9 @@ Standards-Version: 4.7.0 Rules-Requires-Root: no Build-Depends: debhelper-compat (= 13), + clang [arm64], + lld [arm64], + llvm [arm64], gcc-mingw-w64-i686 [i386], gcc-mingw-w64-x86-64 [amd64], libz-mingw-w64-dev, diff --git a/debian/patches/arm/gcc.patch b/debian/patches/arm/gcc.patch deleted file mode 100644 index 7e1fbad836b..00000000000 --- a/debian/patches/arm/gcc.patch +++ /dev/null @@ -1,14 +0,0 @@ -description: build with gcc instead of clang on arm64 -author: Michael Gilbert <mgilb...@debian.org> - ---- a/configure.ac -+++ b/configure.ac -@@ -1047,7 +1047,7 @@ This is an error since --enable-archs=$w - LDFLAGS=$saved_LDFLAGS - done - --if test $HOST_ARCH = aarch64 -+if test $HOST_ARCH = "" - then - test "x$PE_ARCHS" != x || AC_MSG_ERROR([PE cross-compilation is required f or ARM64, please install clang/llvm-dlltool/lld, or llvm-mingw.]) - DLLEXT="" diff --git a/debian/patches/series b/debian/patches/series index 2680f9f650b..d2e3f1f30f0 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -32,7 +32,6 @@ fixes/virtual-protect.patch fixes/printer-resolution.patch fixes/temporary-directory.patch -arm/gcc.patch arm/binary-name.patch arm/shift-overflow.patch arm/format-strings.patch diff --git a/debian/rules b/debian/rules index 1ee433c6065..69c37d2d972 100755 --- a/debian/rules +++ b/debian/rules @@ -69,10 +69,11 @@ ifeq ($(DEB_HOST_ARCH), armhf) CONFLAGS+=--with-float-abi=hard --with-unwind=no endif -# the x18 register is reserved in windows on arm64, avoid clobbering it -# (see https://bugs.winehq.org/show_bug.cgi?id=38780) ifeq ($(DEB_HOST_ARCH), arm64) -export DEB_CFLAGS_MAINT_APPEND+=-ffixed-x18 +# -fstack-clash-protection is not supported by Clang on arm64, and +# if removed from DEB_BUILD_MAINT_OPTIONS, -fno-stack-clash-protection +# is passed instead. +export DEB_CFLAGS_MAINT_APPEND+=-Wno-unused-command-line-argument -Wno-error endif # ignore arm-specific unused functions ``` Unfortunately, the build isn't entirely warning free, so in my testing above, I've just added a -Wno- option to disable a warning, and -Wno-error to avoid treating all warnings as errors. (I understand that this isn't kosher for proper upstream.) This is the same root cause as in Wine bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1093197 (Wine 10.0 FTBFS on arm*). -- Package-specific info: /usr/bin/wine points to /usr/bin/wine-stable. -- System Information: Debian Release: trixie/sid APT prefers testing APT policy: (500, 'testing') Architecture: arm64 (aarch64) Kernel: Linux 6.8.0-1017-oracle (SMP w/4 CPU threads) Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: unable to detect Versions of packages wine depends on: ii wine64 9.0~repack-7 wine recommends no packages. Versions of packages wine suggests: pn dosbox <none> pn exe-thumbnailer | kio-extras <none> pn playonlinux <none> pn q4wine <none> pn winbind <none> pn wine-binfmt <none> pn winetricks <none> Versions of packages libwine depends on: ii libasound2t64 1.2.13-1+b1 ii libc6 2.41-4 ii libcapi20-3t64 1:3.27-3.2+b1 ii libfontconfig1 2.15.0-2.1 ii libfreetype6 2.13.3+dfsg-1 ii libglib2.0-0t64 2.84.0-2 ii libgphoto2-6t64 2.5.31-4 ii libgphoto2-port12t64 2.5.31-4 ii libgstreamer-plugins-base1.0-0 1.25.90-2 ii libgstreamer1.0-0 1.25.90-2 ii libpcap0.8t64 1.10.5-2 ii libpcsclite1 2.3.1-1 ii libpulse0 17.0+dfsg1-2+b1 ii libudev1 257.4-3 ii libunwind8 1.8.1-0.1 ii libusb-1.0-0 2:1.0.27-2 ii libwayland-client0 1.23.1-3 ii libx11-6 2:1.8.10-2 ii libxext6 2:1.3.4-1+b3 ii libxkbcommon0 1.7.0-2 ii libxkbregistry0 1.7.0-2 ii libz-mingw-w64 1.3.1+dfsg-2 ii ocl-icd-libopencl1 [libopencl1] 2.3.2-1+b2 Versions of packages libwine recommends: ii fonts-liberation 1:2.1.5-3 ii fonts-wine 9.0~repack-7 ii gstreamer1.0-plugins-good 1.25.90-2 ii libasound2-plugins 1.2.12-2+b1 ii libcups2t64 2.4.10-2+b1 ii libdbus-1-3 1.16.2-2 ii libgl1 1.7.0-1+b2 ii libgl1-mesa-dri 25.0.1-2 ii libgnutls30t64 3.8.9-2 ii libgssapi-krb5-2 1.21.3-5 ii libkrb5-3 1.21.3-5 ii libodbc2 2.3.12-2 ii libosmesa6 25.0.1-2 ii libsdl2-2.0-0 2.32.2+dfsg-2 ii libv4l-0t64 1.28.1-1 ii libvulkan1 1.4.304.0-1 ii libxcomposite1 1:0.4.6-1 ii libxcursor1 1:1.2.3-1 ii libxfixes3 1:6.0.0-2+b4 ii libxi6 2:1.8.2-1 ii libxinerama1 2:1.1.4-3+b3 ii libxrandr2 2:1.5.4-1+b3 ii libxrender1 1:0.9.10-1.1+b4 ii libxxf86vm1 1:1.1.4-1+b4 Versions of packages libwine suggests: pn cups-bsd <none> pn gstreamer1.0-libav <none> pn gstreamer1.0-plugins-bad <none> pn gstreamer1.0-plugins-ugly <none> pn ttf-mscorefonts-installer <none> Versions of packages wine64 depends on: ii libc6 2.41-4 ii libwine 9.0~repack-7 Versions of packages wine64 recommends: pn wine32 <none> Versions of packages wine64 suggests: pn wine64-preloader <none> Versions of packages wine is related to: pn dxvk <none> pn dxvk-wine32-development <none> pn dxvk-wine64-development <none> ii fonts-wine 9.0~repack-7 -- no debconf information
