Hi,

On 2025-03-08 18:20, Aurelien Jarno wrote:
> control: tag -1 + patch
> 
> Hi,
> 
> On 2025-03-01 21:03, Santiago Vila wrote:
> > Package: src:rt-app
> > Version: 1.0-1.1
> > Severity: serious
> > Tags: ftbfs trixie sid
> > 
> > Dear maintainer:
> > 
> > During a rebuild of all packages in unstable, your package failed to build:
> > 
> 
> This build failure is due to glibc 2.41 which started to define
> sched_setattr() and struct sched_attr. I am sorry I missed this when
> preparing this version.
> 
> I have sent a patch upstream to fix the issue:
> https://github.com/scheduler-tools/rt-app/pull/136
> 
> As the version in debian is slightly outdated, the patch does not apply
> directly, I have attached an adapted version.

This issue, introduced by glibc 2.41, is going to cause rt-app to get
removed from testing, and thus to not get released with Trixie. I have
therefore prepared a non-maintainer upload using the patch in the BTS
and uploaded it to DELAYED/15. Please find the corresponding debdiff
attached.

Please feel free to upload a different fix in the meantime, ask me to
delay further the NMU or to cancel it.

Regards,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurel...@aurel32.net                     http://aurel32.net
diff -Nru rt-app-1.0/debian/changelog rt-app-1.0/debian/changelog
--- rt-app-1.0/debian/changelog 2025-01-01 16:55:19.000000000 +0100
+++ rt-app-1.0/debian/changelog 2025-03-14 22:41:52.000000000 +0100
@@ -1,3 +1,10 @@
+rt-app (1.0-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add patch to fix build with glibc 2.41 (Closes: #1099285)
+
+ -- Aurelien Jarno <aure...@debian.org>  Fri, 14 Mar 2025 22:41:52 +0100
+
 rt-app (1.0-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru rt-app-1.0/debian/patches/glibc-2.41.patch 
rt-app-1.0/debian/patches/glibc-2.41.patch
--- rt-app-1.0/debian/patches/glibc-2.41.patch  1970-01-01 01:00:00.000000000 
+0100
+++ rt-app-1.0/debian/patches/glibc-2.41.patch  2025-03-14 22:29:35.000000000 
+0100
@@ -0,0 +1,77 @@
+Description: Fix build with GNU libc 2.41
+Author: Aurelien Jarno <aurel...@aurel32.net>
+Last-Update: 2025-03-08
+Bug-Debian: http://bugs.debian.org/1099285
+Forwarded: https://github.com/scheduler-tools/rt-app/pull/136
+
+--- rt-app-1.0.orig/configure.ac
++++ rt-app-1.0/configure.ac
+@@ -16,7 +16,7 @@ AC_CHECK_LIB([pthread], [pthread_create]
+ AC_CHECK_LIB([m], [round])
+ AC_CHECK_LIB([rt], [clock_gettime])
+ AC_CHECK_LIB([json-c], [json_object_from_file])
+-AC_CHECK_FUNCS(sched_setattr, [], [])
++AC_CHECK_FUNCS(sched_setattr, [have_sched_settattr=yes], 
[have_sched_settattr=no])
+ 
+ AC_ARG_WITH([deadline],
+       [AS_HELP_STRING([--with-deadline], 
+@@ -24,7 +24,7 @@ AC_ARG_WITH([deadline],
+       [AC_DEFINE([DLSCHED], [1], [Define if you have SCHED_DEADLINE 
support])], 
+       [with_deadline=no])
+ 
+-AM_CONDITIONAL([SET_DLSCHED], [test x$with_deadline != xno && test 
!HAVE_SCHED_SETATTR])
++AM_CONDITIONAL([SET_DLSCHED], [test x$with_deadline != xno && test 
x$have_sched_settattr = xno])
+ 
+ AC_ARG_VAR([LOGLVL], [verbosity level, from 0 to 100. 100 is very verbose])
+ 
+--- rt-app-1.0.orig/src/rt-app_args.c
++++ rt-app-1.0/src/rt-app_args.c
+@@ -19,6 +19,7 @@ along with this program; if not, write t
+ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, 
USA.
+ */
+ 
++#define _GNU_SOURCE
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <string.h>
+--- rt-app-1.0.orig/src/rt-app_parse_config.c
++++ rt-app-1.0/src/rt-app_parse_config.c
+@@ -25,6 +25,7 @@ Foundation, Inc., 51 Franklin Street, Fi
+ #include <stdio.h>
+ #include <string.h>
+ #include <fcntl.h>
++#include <unistd.h>
+ #include <json-c/json.h>
+ 
+ #include "rt-app_utils.h"
+--- rt-app-1.0.orig/src/rt-app_types.h
++++ rt-app-1.0/src/rt-app_types.h
+@@ -25,7 +25,10 @@ Foundation, Inc., 51 Franklin Street, Fi
+ #include <pthread.h>
+ 
+ #include "config.h"
++
++#ifndef HAVE_SCHED_SETATTR
+ #include "dl_syscalls.h"
++#endif
+ 
+ #define RTAPP_POLICY_DESCR_LENGTH 16
+ #define RTAPP_RESOURCE_DESCR_LENGTH 16
+--- rt-app-1.0.orig/src/rt-app_utils.c
++++ rt-app-1.0/src/rt-app_utils.c
+@@ -19,12 +19,15 @@ along with this program; if not, write t
+ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, 
USA.
+ */
+ 
++#define _GNU_SOURCE
+ #include <stdlib.h>
+ #include <stdio.h>
+ #include <string.h>
+ #include <errno.h>
+ #include <math.h>
+ #include <stdarg.h>
++#include <unistd.h>
++#include <sys/syscall.h>
+ 
+ #include "rt-app_utils.h"
+ 
diff -Nru rt-app-1.0/debian/patches/series rt-app-1.0/debian/patches/series
--- rt-app-1.0/debian/patches/series    2021-01-01 05:55:59.000000000 +0100
+++ rt-app-1.0/debian/patches/series    2025-03-14 22:29:35.000000000 +0100
@@ -1,3 +1,4 @@
 longlong-u64.diff
 new-jsoncpp.patch
 python3-conversion.patch
+glibc-2.41.patch

Attachment: signature.asc
Description: PGP signature

Reply via email to