Package: cloop-src
Version: 3.14.1.3+nmu1
Severity: serious
cloop-src fails to build a module for Linux 6.1 in bookworm
(and of course also for 6.12 in trixie).
The attached patch adds an autopkgtest that tries to compile the module
s.t. such breakage can be detected more quickly in the future.
Shouldn't this package have a corresponding -dkms package?
I: Trying to build cloop-src for 6.1.0-29-amd64
Extracting the package tarball, /usr/src/cloop.tar.xz, please wait...
rm -rf *.ko debian/cloop-module-6.1.0-29-amd64
/usr/bin/make -f debian/rules kdist_clean kdist_config binary-modules
make[1]: Entering directory '/usr/src/modules/cloop'
rm -rf *.ko debian/cloop-module-6.1.0-29-amd64
+ for templ in /usr/src/modules/cloop/debian/cloop-module-_KVERS_.config
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst.modules.in
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postrm
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.templ
ates
++ echo /usr/src/modules/cloop/debian/cloop-module-_KVERS_.config
++ sed -e s/_KVERS_/6.1.0-29-amd64/g
+ cp /usr/src/modules/cloop/debian/cloop-module-_KVERS_.config
/usr/src/modules/cloop/debian/cloop-module-6.1.0-29-amd64.config
+ for templ in /usr/src/modules/cloop/debian/cloop-module-_KVERS_.config
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst.modules.in
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postrm
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.templ
ates
++ sed -e s/_KVERS_/6.1.0-29-amd64/g
++ echo /usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst.modules.in
+ cp /usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst.modules.in
/usr/src/modules/cloop/debian/cloop-module-6.1.0-29-amd64.postinst.modules.in
+ for templ in /usr/src/modules/cloop/debian/cloop-module-_KVERS_.config
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst.modules.in
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postrm
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.templ
ates
++ echo /usr/src/modules/cloop/debian/cloop-module-_KVERS_.postrm
++ sed -e s/_KVERS_/6.1.0-29-amd64/g
+ cp /usr/src/modules/cloop/debian/cloop-module-_KVERS_.postrm
/usr/src/modules/cloop/debian/cloop-module-6.1.0-29-amd64.postrm
+ for templ in /usr/src/modules/cloop/debian/cloop-module-_KVERS_.config
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst.modules.in
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postrm
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.templ
ates
++ sed -e s/_KVERS_/6.1.0-29-amd64/g
++ echo /usr/src/modules/cloop/debian/cloop-module-_KVERS_.templates
+ cp /usr/src/modules/cloop/debian/cloop-module-_KVERS_.templates
/usr/src/modules/cloop/debian/cloop-module-6.1.0-29-amd64.templates
+ for templ in
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst.modules.in
/usr/src/modules/cloop/debian/control.modules.in
+ : generate /usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst
+ test '!' -e /usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst
+ sed -e 's/##KVERS##/6.1.0-29-amd64/g ;s/#KVERS#/6.1.0-29-amd64/g ;
s/_KVERS_/6.1.0-29-amd64/g ; s/##KDREV##/6.1.123-1/g ; s/#KDREV#/6.1.123-1/g ;
s/_KDREV_/6.1.123-1/g '
+ for templ in
/usr/src/modules/cloop/debian/cloop-module-_KVERS_.postinst.modules.in
/usr/src/modules/cloop/debian/control.modules.in
+ : generate /usr/src/modules/cloop/debian/control
+ test '!' -e /usr/src/modules/cloop/debian/control
+ test -e /usr/src/modules/cloop/debian/control.backup
+ cp /usr/src/modules/cloop/debian/control
/usr/src/modules/cloop/debian/control.backup
+ sed -e 's/##KVERS##/6.1.0-29-amd64/g ;s/#KVERS#/6.1.0-29-amd64/g ;
s/_KVERS_/6.1.0-29-amd64/g ; s/##KDREV##/6.1.123-1/g ; s/#KDREV#/6.1.123-1/g ;
s/_KDREV_/6.1.123-1/g '
/usr/bin/make module KERNEL_DIR=/lib/modules/6.1.0-29-amd64/build
KVERSION=6.1.0-29-amd64
make[2]: Entering directory '/usr/src/modules/cloop'
Building for Kernel Patchlevel 6
/usr/bin/make modules -C /lib/modules/6.1.0-29-amd64/build
M=/usr/src/modules/cloop
make[3]: Entering directory '/usr/src/linux-headers-6.1.0-29-amd64'
CC [M] /usr/src/modules/cloop/cloop.o
/usr/src/modules/cloop/cloop.c: In function ‘cloop_queue_rq’:
/usr/src/modules/cloop/cloop.c:471:32: error: ‘struct request’ has no member
named ‘rq_disk’
471 | struct cloop_device *clo = req->rq_disk->private_data;
| ^~
/usr/src/modules/cloop/cloop.c: In function ‘cloop_alloc’:
/usr/src/modules/cloop/cloop.c:1175:2: error: implicit declaration of function
‘blk_cleanup_disk’; did you mean ‘blk_alloc_disk’?
[-Werror=implicit-function-declaration]
1175 | blk_cleanup_disk(clo->clo_disk);
| ^~~~~~~~~~~~~~~~
| blk_alloc_disk
cc1: some warnings being treated as errors
make[4]: ***
[/usr/src/linux-headers-6.1.0-29-common/scripts/Makefile.build:255:
/usr/src/modules/cloop/cloop.o] Error 1
make[3]: *** [/usr/src/linux-headers-6.1.0-29-common/Makefile:2034:
/usr/src/modules/cloop] Error 2
make[3]: Leaving directory '/usr/src/linux-headers-6.1.0-29-amd64'
make[2]: *** [Makefile:47: cloop.ko] Error 2
make[2]: Leaving directory '/usr/src/modules/cloop'
make[1]: *** [debian/rules:13: binary-modules] Error 2
make[1]: Leaving directory '/usr/src/modules/cloop'
make: *** [/usr/share/modass/include/common-rules.mk:56: kdist_build] Error 2
ESC[7mBUILD FAILED!
ESC[27mSee /var/cache/modass/cloop-src.buildlog.6.1.0-29-amd64.1738806017 for
details.
Build failed. Press Return to continue...
Andreas
>From 78d70ff156c2be3233397f471e89de3bd5df8b46 Mon Sep 17 00:00:00 2001
From: Andreas Beckmann <a...@debian.org>
Date: Thu, 6 Feb 2025 02:27:26 +0100
Subject: [PATCH] add autopkgtest
---
debian/changelog | 7 +++++++
debian/tests/control | 11 +++++++++++
2 files changed, 18 insertions(+)
create mode 100644 debian/tests/control
diff --git a/debian/changelog b/debian/changelog
index f5efc6a..3c4e8e1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+cloop (3.14.1.3+nmu2) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Add autopkgtest.
+
+ -- Andreas Beckmann <a...@debian.org> Thu, 06 Feb 2025 02:25:32 +0100
+
cloop (3.14.1.3+nmu1) unstable; urgency=medium
* Non-maintainer upload
diff --git a/debian/tests/control b/debian/tests/control
new file mode 100644
index 0000000..f296144
--- /dev/null
+++ b/debian/tests/control
@@ -0,0 +1,11 @@
+Test-Command: /usr/share/modass/module-assistant-autopkgtest cloop-src
+Features: test-name=m-a-autopkgtest
+Depends:
+ cloop-src,
+ module-assistant-autopkgtest,
+ linux-doc,
+Restrictions:
+ superficial,
+ needs-root,
+ breaks-testbed,
+ allow-stderr,
--
2.39.5
