Source: icdiff Version: 2.0.7-3 Severity: serious Tags: patch ftbfs Justification: fails to build from source X-Debbugs-Cc: cru...@debian.org
Dear Maintainer, Your package icdiff runs its source code linters, including "black", during its autopkgtests. This means that newer versions of those linters can cause your autopkgtests to fail even when your package itself has nothing wrong with it. Attached is a patch to skip running the linters, which will help version 25.1.0 of the "black" package eventually migrate to Testing. Thanks!
From d1926c58afe5aabf17d9a50a9221c698014945fe Mon Sep 17 00:00:00 2001
From: "Michael R. Crusoe" <cru...@debian.org>
Date: Thu, 30 Jan 2025 10:15:04 +0100
Subject: [PATCH 1/1] New patch: skip running code linters.
---
.../0001-Skip-running-code-linters.patch | 37 +++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 38 insertions(+)
create mode 100644 debian/patches/0001-Skip-running-code-linters.patch
create mode 100644 debian/patches/series
diff --git a/debian/patches/0001-Skip-running-code-linters.patch b/debian/patches/0001-Skip-running-code-linters.patch
new file mode 100644
index 0000000..c70c6c3
--- /dev/null
+++ b/debian/patches/0001-Skip-running-code-linters.patch
@@ -0,0 +1,37 @@
+From: "Michael R. Crusoe" <cru...@debian.org>
+Date: Thu, 30 Jan 2025 10:13:13 +0100
+Subject: Skip running code linters
+
+Forwarded: not-needed
+
+Not needed for package-level testing, and will cause unnecessary test
+failures when there are newer versions of black and flake8.
+---
+ test.sh | 14 --------------
+ 1 file changed, 14 deletions(-)
+
+diff --git a/test.sh b/test.sh
+index 1dd6c4b..dc9ecab 100755
+--- a/test.sh
++++ b/test.sh
+@@ -210,20 +210,6 @@ function ensure_installed() {
+ fi
+ }
+
+-ensure_installed "black"
+-echo 'Running black formatter...'
+-if ! black icdiff --quiet --line-length 79 --check; then
+- echo ""
+- echo 'Consider running `black icdiff --line-length 79`'
+- fail
+-fi
+-
+-ensure_installed "flake8"
+-echo 'Running flake8 linter...'
+-if ! flake8 icdiff; then
+- fail
+-fi
+-
+ if ! $REGOLD; then
+ echo PASS
+ fi
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..4d79aab
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+0001-Skip-running-code-linters.patch
--
2.43.0
OpenPGP_signature.asc
Description: OpenPGP digital signature
