Your message dated Wed, 29 Jan 2025 05:04:41 +0000 with message-id <e1td0fl-005g1u...@fasolo.debian.org> and subject line Bug#1076689: fixed in litecoin 0.21.4-1 has caused the Debian Bug report #1076689, regarding litecoin:FTBFS:build failure (error: too few arguments to function) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1076689: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076689 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: litecoin Version: 0.21.3-1 Severity: serious Tags: FTBFS, patch User: debian-ri...@lists.debian.org Usertags: riscv64 X-Debbugs-Cc: debian-ri...@lists.debian.org Dear litecoin Maintainer, The package litecoin build failed on all arch.The crucial buildd log below: ``` g++ -std=c++14 -DHAVE_CONFIG_H -I. -I../src/config -I. -I./secp256k1-zkp/include -DBOOST_SP_USE_STD_ATOMIC -DBOOST_AC_USE_STD_ATOMIC -pthread -I/usr/include -I./libmw/include -I./libmw/deps/caches/include -I./libmw/deps/ghc/include -I./libmw/deps/mio/include -I./univalue/include -I. -I./libmw/include -I./libmw/deps/crypto/include -Wdate-time -D_FORTIFY_SOURCE=2 -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -fstack-reuse=none -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fPIC -fno-extended-identifiers -c -o libbitcoin_server_a-net_processing.o `test -f 'net_processing.cpp' || echo './'`net_processing.cpp net.cpp: In function ‘void ThreadMapPort()’: net.cpp:1640:25: error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’ 1640 | r = UPNP_GetValidIGD(devlist, &urls, &data, lanaddr, sizeof(lanaddr)); | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from net.cpp:40: /usr/include/miniupnpc/miniupnpc.h:122:1: note: declared here 122 | UPNP_GetValidIGD(struct UPNPDev * devlist, | ^~~~~~~~~~~~~~~~ g++ -std=c++14 -DHAVE_CONFIG_H -I. -I../src/config -I. -I./secp256k1-zkp/include -DBOOST_SP_USE_STD_ATOMIC -DBOOST_AC_USE_STD_ATOMIC -pthread -I/usr/include -I./libmw/include -I./libmw/deps/caches/include -I./libmw/deps/ghc/include -I./libmw/deps/mio/include -I./univalue/include -I. -I./libmw/include -I./libmw/deps/crypto/include -Wdate-time -D_FORTIFY_SOURCE=2 -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -fstack-reuse=none -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fPIC -fno-extended-identifiers -c -o libbitcoin_server_a-noui.o `test -f 'noui.cpp' || echo './'`noui.cpp make[4]: *** [Makefile:12078: libbitcoin_server_a-net.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[4]: Leaving directory '/<<PKGBUILDDIR>>/src' make[3]: *** [Makefile:20568: all-recursive] Error 1 make[3]: Leaving directory '/<<PKGBUILDDIR>>/src' make[2]: *** [Makefile:815: all-recursive] Error 1 make[2]: Leaving directory '/<<PKGBUILDDIR>>' dh_auto_build: error: make -j6 returned exit code 2 make[1]: *** [debian/rules:32: override_dh_auto_build] Error 25 make[1]: Leaving directory '/<<PKGBUILDDIR>>' make: *** [debian/rules:12: build-arch] Error 2 dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2 ``` The full buildd log is here: https://buildd.debian.org/status/fetch.php?pkg=litecoin&arch=amd64&ver=0.21.3-1%2Bb2&stamp=1730765178&raw=0 My solution to this issue: According to the error message, the issue lies in the call to the UPNP_GetValidIGD function, indicating an insufficient number of arguments. In newer versions, the function signature of UPNP_GetValidIGD has been updated with additional parameters, such as char *errorMsg and int errorMsgLen. I resolved the issue by adding the required parameters for the new version, while also incorporating conditional checks to ensure compatibility with older versions of miniupnpc.I have tested this solution locally,and it works well.The debpatch is in the attachment.Please let me know whether this solution can be accepted. Gui-Yue Best regards
fix_litecoin_build_failed.patch
Description: Binary data
--- End Message ---
--- Begin Message ---Source: litecoin Source-Version: 0.21.4-1 Done: Dmitry Smirnov <only...@debian.org> We believe that the bug you reported is fixed in the latest version of litecoin, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1076...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Dmitry Smirnov <only...@debian.org> (supplier of updated litecoin package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Wed, 29 Jan 2025 15:40:18 +1100 Source: litecoin Architecture: source Version: 0.21.4-1 Distribution: unstable Urgency: medium Maintainer: Dmitry Smirnov <only...@debian.org> Changed-By: Dmitry Smirnov <only...@debian.org> Closes: 1076689 1087899 Changes: litecoin (0.21.4-1) unstable; urgency=medium . * New upstream release. * New patch to fix FTBFS with miniupnpc 2.2.8 (Closes: #1087899, #1076689). Thanks, Gui-Yue, Yangfl. * Build-Depends: prefer "pkgconf" to "pkg-config". Checksums-Sha1: 0735bf5d37e014b0aa0a5a3c2b551da24ba29202 2133 litecoin_0.21.4-1.dsc fb5238770ad607926341b0bde34d0a2b0b8aa6d4 4530084 litecoin_0.21.4.orig.tar.xz 8266ff4efb04cf9ea0f36469d743171a5508dc88 16968 litecoin_0.21.4-1.debian.tar.xz 7a24f347d742028ed80559b8818602bdb22f28fc 20287 litecoin_0.21.4-1_amd64.buildinfo Checksums-Sha256: 4f9b70ba4e5a8bd6ff601e31835cdda522d94c64b9f08ea508c4503797cadaad 2133 litecoin_0.21.4-1.dsc f57e517f114eadc781d990aea1096c7e396f7a94d5f5971ecda95696cd8ac26c 4530084 litecoin_0.21.4.orig.tar.xz 23aa8314b468063bd662f83349c4ae3cf12ecf09299585bf1b6af771314a7823 16968 litecoin_0.21.4-1.debian.tar.xz 8969718cf0271dcfcbf23a6ad69eebe80d49f878dabfc7f0379a5a591266ea35 20287 litecoin_0.21.4-1_amd64.buildinfo Files: 2765e1447996f544d0a5b50bf5b9ac52 2133 utils optional litecoin_0.21.4-1.dsc a60e832a359e5444b7f9d43edbd621bd 4530084 utils optional litecoin_0.21.4.orig.tar.xz 9046e287420fcb623c3032fae276323a 16968 utils optional litecoin_0.21.4-1.debian.tar.xz b92514ebb1c2ad31a213f231352c341b 20287 utils optional litecoin_0.21.4-1_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEULx8+TnSDCcqawZWUra72VOWjRsFAmeZs5oACgkQUra72VOW jRtxgQ//da8q/BryLlfA5YXA0UFciIKmwraSGGYzYfwP/hoMFgX5D2P8ocyYA6y0 KX0UIYu91Rq6PP6pN36nl1ey1N3ZtHOOr3B8zF2coCqR55Kha59HkPjlKJW78UCy 4MFCU7CQXZtS5q4PsBiEcu2mm2E2gSFZCQ5hu4Ogf5X4VyHaX3h75b8fKZ1ps+jP gWuu/CG9mW5vS8dcXt3MuKqTnxsu2i76fBlYXb2hk1MHloNa08HwyPyUx5yEhRGB PEjQOeDsRbA+Fe16Tq1hmXOeaYenQbo4TEo5028/g1Q7dLlmZFwXAMTOM17eoFe/ 6sIz29oFhfq+Mi/es275ENldKLlH7zXG9R3rNzboOov/GerKQ2VNHLSeIXMdDPsQ BmVI3bou2TFAiDK3u6pb8wfGeF6e89cW59xXDBMhSjXV1r1MDOAznBoF4XCyfdJV 4pHFu3VidwSrxrepeUvXlEd4IFns15JeaUy95JQIvZcPJAPDg4oc0oTn34rap3om TmZWFEr/QGteCJnjtT38xD0An1t+CrEEpPD3ok30ncjEgEmv4f8z2zJ5sQI+aFwj MXbuqFcI0Ep6o+TX49Y4RuyJUHFgvcsOdisK3ranV4GMvWFZ+UmYAS6qSANZoZya A1hwOtgbl1J14zD1OB3jNJCBVrRqop9iDLZqeNo17fRjS+RSpmE= =sZSZ -----END PGP SIGNATURE-----
Description: PGP signature
--- End Message ---
