* Bastian Blank <wa...@debian.org> [250106 11:22]: > On Sat, Jan 04, 2025 at 03:56:16PM +0100, Chris Hofstaedtler wrote: > > Hi s390x porters, > > > > DSA (Debian System Administrators) relies on samhain for the > > debian.org infrastructure. > > > > On Wed, Dec 25, 2024 at 01:33:11AM +0100, Chris Hofstaedtler wrote: > > > samhain previously built on s390x but now ftbfs there: > > > > > > https://buildd.debian.org/status/logs.php?suite=sid&arch=s390x&pkg=samhain&ver=4.1.4-4 > > > https://buildd.debian.org/status/fetch.php?pkg=samhain&arch=s390x&ver=4.1.4-4&stamp=1735048699&raw=0 > > > > Can some s390x porters please finally look at this build failure? > > samhain is already gone from testing because of this. > > Not sure how this needs someone with s390 knowledge.
I'm sorry if I implied it needed someone with s390 knowledge. It does however need someone with s390 motivation. > The error is: > > | x_sh_checksum.c:471:22: error: passing argument 2 of ‘sl_memset’ makes > | integer from pointer without a cast [-Wint-conversion] > > Aka this is classic implementation defined behaviour. In C, pointers > are not freely convertable into integers. > > Without reading the source, I would consider this a problem. The > variable is called "state" and this memset primitive leaks 8 (lowest) > bits of the address by spraying it all over the heap. Seems bad, I agree. Chris
