Your message dated Wed, 18 Sep 2024 20:51:39 +0000 with message-id <e1sr1ef-009t0n...@fasolo.debian.org> and subject line Bug#1068782: fixed in libesmtp 1.1.0-3.2 has caused the Debian Bug report #1068782, regarding libesmtp: fixes for t64 and new glibc to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 1068782: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068782 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: libesmtp Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu noble ubuntu-patch X-Debbugs-Cc: michael.hud...@ubuntu.com Dear Maintainer, Apologies for submitting this as only one report. libesmtp was failing on Ubuntu on armhf only because although strlcpy is now in glibc, the declaration is only found if _DEFAULT_SOURCE or _BSD_SOURCE is defined. While looking at this I saw some scary warnings about the date handling in headers.c which I fixed the easy bits of. In Ubuntu, the attached patch was applied to achieve the following: * d/patches/time64: cast time_t values to long long before passing to *printf functions (code storing time_t values in void* variables will still break in 2038). * d/patches/default-source: define _DEFAULT_SOURCE to get access to prototype of strlcpy. Thanks for considering the patch. Cheers, mwh -- System Information: Debian Release: trixie/sid APT prefers mantic-updates APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 'mantic'), (100, 'mantic-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.5.0-27-generic (SMP w/16 CPU threads; PREEMPT) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_NZ.UTF-8:en Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enableddiff -Nru libesmtp-1.1.0/debian/patches/default-source libesmtp-1.1.0/debian/patches/default-source --- libesmtp-1.1.0/debian/patches/default-source 1970-01-01 12:00:00.000000000 +1200 +++ libesmtp-1.1.0/debian/patches/default-source 2024-04-11 11:37:59.000000000 +1200 @@ -0,0 +1,10 @@ +--- a/meson.build ++++ b/meson.build +@@ -30,6 +30,7 @@ + ################################################################################ + cflags = [ + '-D_POSIX_C_SOURCE=200809L', ++ '-D_DEFAULT_SOURCE', + ] + + cflags_warnings = [ diff -Nru libesmtp-1.1.0/debian/patches/series libesmtp-1.1.0/debian/patches/series --- libesmtp-1.1.0/debian/patches/series 2023-08-19 22:04:32.000000000 +1200 +++ libesmtp-1.1.0/debian/patches/series 2024-04-11 11:37:24.000000000 +1200 @@ -1 +1,3 @@ meson-build-soname +time64 +default-source diff -Nru libesmtp-1.1.0/debian/patches/time64 libesmtp-1.1.0/debian/patches/time64 --- libesmtp-1.1.0/debian/patches/time64 1970-01-01 12:00:00.000000000 +1200 +++ libesmtp-1.1.0/debian/patches/time64 2024-04-11 11:37:18.000000000 +1200 @@ -0,0 +1,16 @@ +--- a/headers.c ++++ b/headers.c +@@ -170,11 +170,11 @@ + { + #ifdef HAVE_GETTIMEOFDAY + if (gettimeofday (&tv, NULL) != -1) /* This shouldn't fail ... */ +- snprintf (buf, sizeof buf, "%ld.%ld.%d@%s", tv.tv_sec, tv.tv_usec, ++ snprintf (buf, sizeof buf, "%lld.%lld.%d@%s", (long long)tv.tv_sec, (long long)tv.tv_usec, + getpid (), message->session->localhost); + else /* ... but if it does fall back to using time() */ + #endif +- snprintf (buf, sizeof buf, "%ld.%d@%s", time (NULL), ++ snprintf (buf, sizeof buf, "%lld.%d@%s", (long long)time (NULL), + getpid (), message->session->localhost); + message_id = buf; + }
--- End Message ---
--- Begin Message ---Source: libesmtp Source-Version: 1.1.0-3.2 Done: Salvatore Bonaccorso <car...@debian.org> We believe that the bug you reported is fixed in the latest version of libesmtp, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 1068...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Salvatore Bonaccorso <car...@debian.org> (supplier of updated libesmtp package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Mon, 16 Sep 2024 21:36:36 +0200 Source: libesmtp Architecture: source Version: 1.1.0-3.2 Distribution: unstable Urgency: medium Maintainer: Jeremy T. Bouse <jbo...@debian.org> Changed-By: Salvatore Bonaccorso <car...@debian.org> Closes: 1068782 1071322 Changes: libesmtp (1.1.0-3.2) unstable; urgency=medium . * Non-maintainer upload. . [ Michael Hudson-Doyle ] * d/patches/time64: cast time_t values to long long before passing to *printf functions (code storing time_t values in void* variables will still break in 2038). (Closes: #1068782) * d/patches/default-source: define _DEFAULT_SOURCE to get access to prototype of strlcpy. (Closes: #1071322) Checksums-Sha1: cfce628b81dd19f94cb14874aedd3f9f57045392 2100 libesmtp_1.1.0-3.2.dsc ea432ef844da70d53d8491d9806fb25ce25223bd 5504 libesmtp_1.1.0-3.2.debian.tar.xz Checksums-Sha256: a2215617322d1b34526eb1b057058628cd761ee54f005e18ccf438b8e4dcb84a 2100 libesmtp_1.1.0-3.2.dsc 9c387bba89a9bb1355271f052ddb52d85700595ff271aa63663bd21009b20440 5504 libesmtp_1.1.0-3.2.debian.tar.xz Files: 0da1e2189f7aac6f01f62f9550426abd 2100 libs optional libesmtp_1.1.0-3.2.dsc 16104e243f93129cf4827e58f799ed8b 5504 libs optional libesmtp_1.1.0-3.2.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmboiYJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDQ2 NDQ0MDk4MDhDMTcxRTA1NTMxRERFRTA1NENCOEYzMTM0M0NGNDQSHGNhcm5pbEBk ZWJpYW4ub3JnAAoJEAVMuPMTQ89EBeoP/1kqHXM7o3/wqFJXytPT+phe8kf2tg0l PylBVS1LNkDTOe1aoN1OmeuW66kks2qxqxZ8un/NlyYzN4Sa7rVyE1kWehWWJPOY 3KhiP4SPYKd0dD+TFuFvduoQgbQKoDj2FEfVBtFzpy1Mj/dte1NfJQ7O2mVubSwG wxB/ajwmk4ZfiEf77n6HmkAk5F7mvEqEKX5KIC5ENWRTvxOoq92UHGcrP9kvi5vO 5MuYIBlHblpa5yS/zDh9C5tlCHwwZRGzwHLeceLkh0HYZeNkAbNdTXzybVG5awC8 yIiBcJvYlm8j+WleMliVLhJF3gC/P4e8+j3sqUIPy8Nl0iVxyKHq+MXeNuEyA+Ro 6Zgc+OW2xRkVn9RkWF2Whpa7mzysaLhVVA2TPBQVSTusxZOsaX/s+4v5dGUWE0Eh OryA3eGwklgIii4TU8V32+YuCmwpQ1XLd+PSP2z1+Z+lXRB6G5rcqe2ldblRFfia vZAK03kXdlaiSYFa17NxcWbkqDvX+BcttBj0HMcDDSAp0GtKTGKweOx9lOdsA5l3 WS+NtdgSuXxYf8oqEmaPs9PL18GZQHgbNVxATRYljieL/KIUkot9ShgAkwvQU0jL rhbXiNId24Jd72uMCSp7Z5KSF8RPhvRZrTjpJPirAUBGEDOAKSC7YqwpJjBhhLUT lmQlC9/sSuDs =JSeB -----END PGP SIGNATURE-----
pgpTYZ1vUhxEK.pgp
Description: PGP signature
--- End Message ---
