Quoting noisyc...@tutanota.com (2024-08-26 19:30:29)
> > Also, would be neat if the patch was improved to not fail but lower
> optimization level and emit a warning.
> 
> I liked the idea so I started playing around a bit. While I haven't
> found a way to achieve that yet (simply setting environment variables
> doesn't seem to work and there doesn't seem to be a facility for
> setting arbitrary rustflags from within build.rs) I found out that
> your patch will likely not work on Debian infra. Apparently, the `cfg`
> checks in build.rs (and build.rs only) apply to the build machine, not
> to the target, and on Debian's infra the i386 binaries are usually if
> not exclusively built on amd64 machines, so the empty main function
> will be built instead. I'm going to send you a MR to fix this.

Evidently an x86 CI run for rust-wide 0.7.28-3 succeeded, which seems to
contradict your findings above: Apparently my patch *does* work.  Or am
I misunderstanding something?

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/
 * Sponsorship: https://ko-fi.com/drjones

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: signature

Reply via email to