On Sun, Aug 04, 2024 at 10:38:41PM +0300, Niko Tyni wrote: > Control: tag -1 patch > > On Wed, Jul 03, 2024 at 12:34:06PM +0000, Matthias Klose wrote: > > Package: src:libprelude > > Version: 5.2.0-5.5 > > Severity: important > > Tags: sid trixie > > User: debian-...@lists.debian.org > > Usertags: ftbfs-gcc-14
> > idmef-class.c: In function ‘idmef_class_get_child_attributes’: > > idmef-class.c:164:24: error: returning ‘int’ from a function with return > > type ‘const char **’ makes pointer from integer without a cast > > [-Wint-conversion] > > 164 | return ret; > > | ^~~ > > make[6]: *** [Makefile:1813: idmef-class.lo] Error 1 > > This looks like a copy-paste bug as returning an int as char ** > doesn't make much sense. Presumably the right thing is to return > NULL, as in the attached trivial patch. FWIW looks like Fedora has a similar patch applied: https://src.fedoraproject.org/rpms/libprelude/c/c4132843c77c67b1e68995f433abbc9e187e6b2c?branch=rawhide -- Niko
