On Wed, 07 Aug 2024 00:30:47 +0300, Niko Tyni wrote:

> Rebuilding this package on current sid produces an empty package.

Ouch.
Once again …
 
> So this is a GCC 14 related regression and is fixed by including
> the gcrypt.h header with the version check. Patch attached.

Great!
 
> As for not failing the build, looks like the upstream part of that is
> intentional so that CPAN testers don't report failures due to lack of
> external libraries.

Ack, quite common behaviour.

> Not sure where that leaves us. Some solutions I can think of:
> - patch Makefile.PL to use assert_lib() instead 
> - add a check in debian/rules to detect the failure
> - call dh explicitly with --buildsystem=perl_makemaker 
> - change dh to fail the build if 'perl Makefile.PL' does not produce a 
> Makefile

There is prior art for the first option (assert_lib()):

% grep assert_lib ../*/debian/patches/*
../libauthen-krb5-simple-perl/debian/patches/fix-checklib-fail.patch:+assert_lib(
../libcrypt-dh-gmp-perl/debian/patches/fix-checklib-fail.patch:+    
Devel::CheckLib::assert_lib(@dcl_args);
../libdata-structure-util-perl/debian/patches/fix-checklib-fail.patch:+assert_lib();
../libipc-sharelite-perl/debian/patches/fix-checklib-fail.patch:+assert_lib();
../libmath-tamuanova-perl/debian/patches/fix-checklib-fail.patch:+assert_lib(
../libopengl-xscreensaver-perl/debian/patches/fix-checklib-fail.patch:+assert_lib(lib
 => ['X11', 'GL']);

> The last option is the only generic one, but might interfere
> with the dh buildsystem automatic detection.

Hm, something generic would be nice but I'm also a bit afraid of side
effects.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   

Attachment: signature.asc
Description: Digital Signature

Reply via email to