在 2024-08-03星期六的 13:31 +0200,Michael Biebl写道:
> On Thu, 25 Jul 2024 14:05:44 +0200 Helmut Grohne <hel...@subdivi.de>
> wrote:
> > Package: ipwatchd
> > Version: 1.3.0-1+nmu1
> > Severity: serious
> > Justification: do not introduce aliased files into trixie
> > X-Debbugs-Cc: YunQiang Su <s...@debian.org>
> > User: helm...@debian.org
> > Usertags: dep17m2
> > Filename: /lib/systemd/system/ipwatchd.service
> > 
> > Hi,
> > 
> > your last upload added /lib/systemd/system/ipwatchd.service, which
> > is an
> > aliased location. We should not add any aliased files to trixie at
> > this
> > time hence filing at rc severity. Please move the unit to /usr. A
> > simple
> > way is adding dh-sequence-movetousr to Build-Depends. Consider
> > doing the
> > move in the upstream build system instead or relying on pkgconf
> > --variable systemdsystemunitdir systemd to provide the target
> > location.
> 
> 
> I also noticed, that the package added a Pre-Depends on 
> init-system-helpers (>= 1.66) without a proper explanation why.
> 

lintian warned about that when I didn't add it.

> Also, you probably should call dh_installsystemd as part of
> debian/rules 

Yes. I guess that we should switch debian/rules to the style of
override_..

> (dh does this automatically for you), to ensure that the service is 
> properly enabled and (re)started.
> 
> Regards,
> Michael

Reply via email to