tag 380466 + patch
thanks
On Sat, Aug 26, 2006 at 09:05:31AM +0300, Yavor Doganov <[EMAIL PROTECTED]>
wrote:
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread -1503189312 (LWP 29660)]
> 0xa7e56bd1 in GtkPromptService::PromptUsernameAndPassword (this=0x8103098,
> aParent=0x88f5270, aDialogTitle=0x0, aDialogText=0x890e610,
> aUsername=0xaf9ef124, aPassword=0xaf9ef120, aCheckMsg=0xaf9eef54,
> aCheckValue=0x0, aConfirm=0xaf9ef440) at GtkPromptService.cpp:350
> 350 kz_prompt_dialog_set_check_value(prompt,
> *aCheckValue);
Well, there's a missing 'if (aCheckValue)' before
kz_prompt_dialog_set_check_value(prompt, *aCheckValue);
on GtkPromptService.cpp:350, like 2 lines later:
if (aCheckValue)
*aCheckValue = kz_prompt_dialog_get_check_value(prompt);
Thank you all for your help. 岩井さん, Attached is a dpatch that should fix the
crasher.
If Yagor or Gerfried could test it, that would be a plus. Just drop the
file in debian/patches and add its name ni debian/patches/00list.
Cheers
Mike
#! /bin/sh /usr/share/dpatch/dpatch-run
## 50_gtkpromptservice.dpatch by <[EMAIL PROTECTED]>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Fixed crasher in GtkPromptService.cpp when aCheckValue is NULL. Thanks
## DP: to Gerfried Fuchs and Yavor Doganov for their help
@DPATCH@
--- kazehakase/src/mozilla/GtkPromptService.cpp.orig 2006-08-26
08:50:40.906614000 +0200
+++ kazehakase/src/mozilla/GtkPromptService.cpp 2006-08-26 08:51:25.313389250
+0200
@@ -347,7 +347,8 @@
if (aCheckMsg)
{
kz_prompt_dialog_set_check_message(prompt, cCheckMsg.get());
- kz_prompt_dialog_set_check_value(prompt, *aCheckValue);
+ if (aCheckValue)
+ kz_prompt_dialog_set_check_value(prompt, *aCheckValue);
}
kz_prompt_dialog_run(prompt);
if (aCheckValue)
