Your message dated Wed, 08 May 2024 11:49:14 +0000
with message-id <[email protected]>
and subject line Bug#1066349: fixed in ace-of-penguins 1.5~rc2-6
has caused the Debian Bug report #1066349,
regarding ace-of-penguins: FTBFS on armhf with implicit function declaration
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1066349: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066349
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ace-of-penguins
Version: 1.5~rc2-5
Severity: serious
Tags: patch
Justification: ftbfs
User: [email protected]
Usertags: origin-ubuntu noble ubuntu-patch
Dear maintainers,
In Ubuntu we see that ace-of-penguins now fails to build on armhf, because
the 64-bit time_t transition means requires
-Werror=implicit-function-declaration to ensure packages pick up the correct
time64 glibc entry point mappings from the headers.
The failure is:
[...]
./make-imglib.c: In function ‘tokenize’:
./make-imglib.c:207:20: error: implicit declaration of function ‘isgraph’
[-Werror=implicit-function-declaration]
207 | while (*next && !isgraph(*next)) next++;
| ^~~~~~~
./make-imglib.c:10:1: note: include ‘<ctype.h>’ or provide a declaration of
‘isgraph’
[...]
(https://launchpad.net/ubuntu/+source/ace-of-penguins/1.5~rc2-5build1/+build/27848688)
Seems easy enough, gcc even tells us which header is missing! See attached
a patch for this which has been uploaded to Ubuntu.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru
ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch
ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch
---
ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch
1969-12-31 16:00:00.000000000 -0800
+++
ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch
2024-02-28 23:00:10.000000000 -0800
@@ -0,0 +1,19 @@
+Description: fix missing function declaration
+ 64-bit time_t requires use of -Werror=implicit-function-declaration,
+ and we have one here - isgraph(). Include the standard header to fix
+ the build failure.
+Author: Steve Langasek <[email protected]>
+Last-Update: 2024-02-28
+Forwarded: no
+Index: ace-of-penguins-1.5~rc2/lib/make-imglib.c
+===================================================================
+--- ace-of-penguins-1.5~rc2.orig/lib/make-imglib.c
++++ ace-of-penguins-1.5~rc2/lib/make-imglib.c
+@@ -5,6 +5,7 @@
+ #include <sys/stat.h>
+ #include <unistd.h>
+ #include <dirent.h>
++#include <ctype.h>
+
+ #include <png.h>
+
diff -Nru ace-of-penguins-1.5~rc2/debian/patches/series
ace-of-penguins-1.5~rc2/debian/patches/series
--- ace-of-penguins-1.5~rc2/debian/patches/series 2023-01-13
13:59:18.000000000 -0800
+++ ace-of-penguins-1.5~rc2/debian/patches/series 2024-02-28
22:58:12.000000000 -0800
@@ -1,2 +1,3 @@
freecell-KDE.patch
gcc10.patch
+no-implicit-function-declaration.patch
--- End Message ---
--- Begin Message ---
Source: ace-of-penguins
Source-Version: 1.5~rc2-6
Done: Reiner Herrmann <[email protected]>
We believe that the bug you reported is fixed in the latest version of
ace-of-penguins, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Reiner Herrmann <[email protected]> (supplier of updated ace-of-penguins
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 04 Apr 2024 19:48:17 +0200
Source: ace-of-penguins
Architecture: source
Version: 1.5~rc2-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Reiner Herrmann <[email protected]>
Closes: 1058017 1065046 1066349
Changes:
ace-of-penguins (1.5~rc2-6) unstable; urgency=medium
.
* Team upload.
.
[ Steve Langasek ]
* Fix missing function declaration. (Closes: #1065046, #1066349)
.
[ Helmut Grohne ]
* Fix FTCBFS by removing confusion between build and host compiler flags.
(Closes: #1058017)
.
[ Reiner Herrmann ]
* Declare that d/rules does not require root.
* Drop -Wl,--as-needed, which is used by default.
* Update lintian-overrides to new format and tag names.
* Use wildcards instead of hardcoded architectures in lintian-overrides.
* Declare compliance with Debian Policy 4.7.0.
Checksums-Sha1:
f0135ff32c38853451ef2369d34b15c6ea5360a0 2086 ace-of-penguins_1.5~rc2-6.dsc
3eba52d7cf2766c331bcb1736a3223618f7a2818 12712
ace-of-penguins_1.5~rc2-6.debian.tar.xz
2edd7c5ad4c9cb98a6d12744570d538c1d1096ba 6605
ace-of-penguins_1.5~rc2-6_source.buildinfo
Checksums-Sha256:
fb55da2f039ac39a38227bb80c6022b23985295462672c04158279029d2f4f51 2086
ace-of-penguins_1.5~rc2-6.dsc
c4baaced0702e1fbfa9aaf8e29f357bee286cf22dd5a1879294d4fdd3b617052 12712
ace-of-penguins_1.5~rc2-6.debian.tar.xz
c6bfdaeb911a06ab21af9141ebd3e0c2f8a86abc37944a499b1bd10b9346e435 6605
ace-of-penguins_1.5~rc2-6_source.buildinfo
Files:
94cae2895c9e406c68c13c391e475257 2086 games optional
ace-of-penguins_1.5~rc2-6.dsc
9cb0a1e4cb0f62e321e8e558b9a839d4 12712 games optional
ace-of-penguins_1.5~rc2-6.debian.tar.xz
0414180ff6d0b81b09afd566130dad44 6605 games optional
ace-of-penguins_1.5~rc2-6_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmY7YwkACgkQMfMURUSh
dBrhfg//fUjoGeGu+pHrcw5cL90EDG7Q2zI4XFK1rGRCwskjLKzwOzaQIevV7+k0
zN2DB3XZbHTjOTR7b/bPVsuB/bKXdRAiu9/xORYOP2E5DET3Rl8ebpAcqBAc+Cat
4vjYjurNvciBEjDD6RykUtmX8kWdpjyn0GNsYYXfc7hPBkrxCWXDiWxcc5uFpe0p
JR3GPgFWlbynPx3ZXreN0k5cH6omEkc/cyFycR0rFg3tlSUGI2FJz7CrAZsqc98W
ud5w3Wbkm2NyHyBVgiCc+unc/i8FrMswx139D88UUozfhMpr88p0FXwzinsZDfUf
k0zB/rPvpZuAiBZ2pRgfdN5pcJD5Gd8BFSOE/d/d/fQXAnWwcUAf3biR4mLukiSB
8TegIiVzgpzpDhYWIW4jtRaUHq2bSB0b6fbwna7WA7BZdcGP7QZPbt9v4s+sgmuI
SM5YSLS/dsSY9ne1XUyd4T428Mp4QjHVZkN41KWD79Pvlf0ranAbRVsVqP2kr3gL
1W2R3JC2Gf6F12cGjsL1hGd97L3KX6BELdBU1kjPyAGwHLBa1KpYzk1/y4Rvnd7K
YEpBRHd8hWemmc7nXd3GxAUUBcXBnD+ixCLvE9ylzsc9LTEA/VFpxYTQtbLJ1ef/
ktEDmZ/rdGAZSQ71kK4/qMH/6OvOr+UIwotzpQCZstsyLU9kI6Q=
=xtuS
-----END PGP SIGNATURE-----
pgpAN8kM95f00.pgp
Description: PGP signature
--- End Message ---
