On Mon, 8 Apr 2024 17:09:33 +0000 Graham Inggs <gin...@debian.org> wrote: > Control: tags -1 + patch > > Hi Maintainer > > While asserting that no warnings are raised is a useful test for the > upstream developers, I don't think it makes sense for downstreams. > > I propose to disable the assertion as follows: > > --- a/tests/test_minimizers.py > +++ b/tests/test_minimizers.py > @@ -117,7 +117,7 @@ > # Should no longer raise warnings, because internally we practice > # what we preach. > fit_custom = BFGS(chi_squared, [a, b]) > - assert len(recwarn) == 0 > +# assert len(recwarn) == 0 > > fit_custom_result = fit_custom.execute() > > Please let me know if you are happy with a team upload and I will proceed. > As a bonus, I attach a patch that fixes several SyntaxWarnings that > occur with Python 3.12.
Hey Graham, A team upload is fine, thanks for the fixes; please go ahead and upload them.
OpenPGP_signature.asc
Description: OpenPGP digital signature