Your message dated Sun, 10 Mar 2024 12:45:54 +0000
with message-id <[email protected]>
and subject line Bug#1065756: fixed in pngnq 1.1+ds-3
has caused the Debian Bug report #1065756,
regarding pngnq: FTBFS on arm{el,hf}: rwpng.c:242:13: error: implicit
declaration of function ‘strncmp’ [-Werror=implicit-function-declaration]
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1065756: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065756
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: pngnq
Version: 1.1+ds-2
Severity: serious
Tags: ftbfs sid trixie
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: [email protected]
https://buildd.debian.org/status/fetch.php?pkg=pngnq&arch=armhf&ver=1.1%2Bds-2%2Bb1&stamp=1709981044&raw=0
gcc -DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 `libpng-config --I_opts` -Wall
--pedantic -std=gnu99 -g -O2 -Werror=implicit-function-declaration
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong
-fstack-clash-protection -Wformat -Werror=format-security -c -o colorspace.o
colorspace.c
rwpng.c: In function ‘rwpng_read_image’:
rwpng.c:242:13: error: implicit declaration of function ‘strncmp’
[-Werror=implicit-function-declaration]
242 | if(!strncmp("author",comments[c].key,6)){
| ^~~~~~~
rwpng.c:40:1: note: include ‘<string.h>’ or provide a declaration of ‘strncmp’
39 | #include "rwpng.h" /* typedefs, common macros, public prototypes */
+++ |+#include <string.h>
40 |
rwpng.c:242:46: warning: ‘strncmp’ argument 3 type is ‘int’ where ‘unsigned
int’ is expected in a call to built-in function declared without prototype
[-Wbuiltin-declaration-mismatch]
242 | if(!strncmp("author",comments[c].key,6)){
| ^
<built-in>: note: built-in ‘strncmp’ declared here
In file included from colorspace.c:7:
colorspace.h:25:18: warning: ‘d00’ defined but not used [-Wunused-variable]
25 | static color_XYZ d00 = {0.0, 0.0, 0.0};
| ^~~
rwpng.c:85:5: warning: ignoring return value of ‘fread’ declared with attribute
‘warn_unused_result’ [-Wunused-result]
85 | fread(sig, 1, 8, infile);
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from pngnq.c:99:
neuquant32.h:59:22: warning: ‘biasvalue’ declared ‘static’ but never defined
[-Wunused-function]
59 | static inline double biasvalue(unsigned int temp);
| ^~~~~~~~~
pngcomp.c: In function ‘main’:
pngcomp.c:118:10: warning: variable ‘block_err_image’ set but not used
[-Wunused-but-set-variable]
118 | float* block_err_image = NULL;
| ^~~~~~~~~~~~~~~
pngcomp.c:108:7: warning: variable ‘verbose’ set but not used
[-Wunused-but-set-variable]
108 | int verbose = 0;
| ^~~~~~~
pngcomp.c: In function ‘printstats’:
pngcomp.c:506:30: warning: format ‘%ld’ expects argument of type ‘long int’,
but argument 2 has type ‘png_uint_32’ {aka ‘unsigned int’} [-Wformat=]
506 | printf("Image Dimensions %ld x %ld
\n",image1_info.width,image1_info.height);
| ~~^ ~~~~~~~~~~~~~~~~~
| | |
| long int png_uint_32 {aka
unsigned int}
| %d
pngcomp.c:506:36: warning: format ‘%ld’ expects argument of type ‘long int’,
but argument 3 has type ‘png_uint_32’ {aka ‘unsigned int’} [-Wformat=]
506 | printf("Image Dimensions %ld x %ld
\n",image1_info.width,image1_info.height);
| ~~^
~~~~~~~~~~~~~~~~~~
| | |
| long int
png_uint_32 {aka unsigned int}
| %d
In file included from pngcomp.c:59:
colorspace.h: At top level:
colorspace.h:25:18: warning: ‘d00’ defined but not used [-Wunused-variable]
25 | static color_XYZ d00 = {0.0, 0.0, 0.0};
| ^~~
colorspace.h:24:18: warning: ‘d65’ defined but not used [-Wunused-variable]
24 | static color_XYZ d65 = {0.94810,1.0000,1.07305};
| ^~~
pngnq.c: In function ‘createoutname’:
pngnq.c:279:7: warning: ‘__builtin_strncpy’ output truncated before terminating
nul copying 1 byte from a string of the same length [-Wstringop-truncation]
279 | strncpy(newdir+dir_len,DIR_SEPARATOR_STR,1);
| ^
cc1: some warnings being treated as errors
make[3]: *** [Makefile:403: rwpng.o] Error 1
Cheers
--
Sebastian Ramacher
--- End Message ---
--- Begin Message ---
Source: pngnq
Source-Version: 1.1+ds-3
Done: xiao sheng wen <[email protected]>
We believe that the bug you reported is fixed in the latest version of
pngnq, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
xiao sheng wen <[email protected]> (supplier of updated pngnq package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 10 Mar 2024 10:14:05 +0800
Source: pngnq
Architecture: source
Version: 1.1+ds-3
Distribution: unstable
Urgency: medium
Maintainer: Debian PhotoTools Maintainers
<[email protected]>
Changed-By: xiao sheng wen <[email protected]>
Closes: 1065756
Changes:
pngnq (1.1+ds-3) unstable; urgency=medium
.
* d/copyright:
- add Upstream-Contact info
- update year info to 2024
* add d/p/rwpng.c-add-include-string.h.patch(Closes: #1065756)
Checksums-Sha1:
e6c2640cfdcaad9ad13b94382c415fe21ec87580 1377 pngnq_1.1+ds-3.dsc
ba8de793ff348a906e67c02194cd7cd488560cca 8420 pngnq_1.1+ds-3.debian.tar.xz
f0a097077c033f23f0b4d59dfafa3d5947c6b746 6054 pngnq_1.1+ds-3_amd64.buildinfo
Checksums-Sha256:
3e381f5bdf3a6024ff4a498fd10c7a389d3cfc6738799f4ff594d4cc1615717b 1377
pngnq_1.1+ds-3.dsc
243abbe9cd81b9d1a6eab42338e36d71a0399e09d3c5e3f18368779c06649a08 8420
pngnq_1.1+ds-3.debian.tar.xz
ee1f0ecbae8dd19391f19e1d95861f04531cf3d6c1fd52173033836bad58cddb 6054
pngnq_1.1+ds-3_amd64.buildinfo
Files:
0270eecbb686970d5f0fcdb84e20a16d 1377 graphics optional pngnq_1.1+ds-3.dsc
ae09ea1a80b38629253d35f2d9ad987b 8420 graphics optional
pngnq_1.1+ds-3.debian.tar.xz
2629128762bfd6d3f5680bd53d53e331 6054 graphics optional
pngnq_1.1+ds-3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQRCYn6EHZln2oPh+pAhk2s2YA/NiQUCZe2hYwAKCRAhk2s2YA/N
iRFGAQCOR7xBRMm5MuTuA/i8Ynhwk6I2jgGDH6MeQhIMF2P9LwEAlDowJ1Zdrt1k
1ShaWG7dvPhdlKVBREHup6OhoSTyzw4=
=Yqeb
-----END PGP SIGNATURE-----
pgpQheU9mwS_Z.pgp
Description: PGP signature
--- End Message ---
