Hi Andrius,
On Tue, Jan 16, 2024 at 10:05:20AM +0200, Andrius Merkys wrote:
Hi Yogeswaran,
On 2024-01-16 03:43, Yogeswaran Umasankar wrote:
I have removed the hard-coded version number from setup.py. I found that
the issue was due to changes in PEP440 version naming convention in
versioneer. For this package no need python3-versioneer, upstream has
its own versioneer.py. The work around is, once have everything in
master branch create a tag with just the version number (0.0.2-1)
instead of debian/version number (debian/0.0.2-1).
This would not work, either. Debian build machines build packages not
from git repositories, but from source packages. Therefore they will
not see git tags. Moreover, one should not deviate from Debian
packaging principles to make a package build, thus Debian git tag
names should not be tampered with.
I have forked python-mpiplus [0] for you to check the changes and to see
how it works before you decide to incorporate the changes. Feel free to
MR the fork and make any further changes needed.
[0] https://salsa.debian.org/yogu/python-mpiplus
Thanks for looking into python-mpiplus, but I have chosen a different
approach to deal with this issue. I removed embedded versioneer.py in
favor of python3-versioneer thus resolving the build issue. This is
not optimal either, as versioneer-derived package version stays
'0+unknown', but this does not seem to be uncommon in Debian [1].
[1] $ apt-file search 0+unknown.egg-info
Thank you for caring for python-mpiplus.
That's neat! I didn't thought of this approach, great learning!
Cheers!
Yogeswaran.