On Sun, 06 Aug 2006 03:34:31 -0700, Devin Carraway <[EMAIL PROTECTED]>
said:
> Package: libselinux Severity: serious Justification: no longer
> builds from source
> This may be the fault of linux-kernel-headers more than libselinux,
> but as of linux-kernel-headers 2.6.17-6-1, I can't build libselinux
> due to undefined symbol errors concerning the use of PAGE_SIZE in a
> number of places. The sources are #including <asm/page.h>, which on
> i386/amd64 actually define something, but on powerpc contain nothing
> at all unless __KERNEL__ is defined.
> Using getpagesize() (e.g. with the attached patch) seems to work
> just fine.
I don't like this patch. It would mean that a assignment to a
constant (which can be optimized away) is being replaced by a
function call -- with all that entails (context switches, branch
misses), etc.
I would much rather do:
#include <asm/page.h>
#ifndef PAGE_SIZE
# define PAGE_SIZE getpagesize()
#endif
and only have the function call penalty hit powerpc
machines. It also minimizes the diff from upstream to three lines,
which is better :)
manoj
--
System checkpoint complete.
Manoj Srivastava <[EMAIL PROTECTED]> <http://www.datasync.com/%7Esrivasta/>
1024D/BF24424C print 4966 F272 D093 B493 410B 924B 21BA DABB BF24 424C
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
