Your message dated Sun, 06 Aug 2023 18:21:56 +0000
with message-id <[email protected]>
and subject line Bug#1007134: fixed in nzbget 21.2~r2333+dfsg-1
has caused the Debian Bug report #1007134,
regarding nzbget: wrong architecture target for source files on armhf
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1007134: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007134
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nzbget
Version: 21.0+dfsg-2
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu jammy ubuntu-patch
Hi Andreas,
The nzbget package is failing to build from source in Ubuntu on armhf,
because Ubuntu's compiler is currently stricter with compiler options than
Debian's:
[...]
g++ -DHAVE_CONFIG_H -I. -I./daemon/connect -I./daemon/extension
-I./daemon/feed -I./daemon/frontend -I./daemon/main -I./daemon/nntp
-I./daemon/postprocess -I./daemon/queue -I./daemon/remote -I./daemon/util
-I./daemon/nserv -I./lib/par2 -I./lib/yencode -Wdate-time -D_FORTIFY_SOURCE=2
-I/usr/include/libxml2 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -g -O2
-ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -fpermissive -march=armv8-a+crc -fpermissive -c -o
lib/yencode/AcleCrc.o lib/yencode/AcleCrc.cpp
cc1plus: error: ‘-mfloat-abi=hard’: selected architecture lacks an FPU
make[2]: *** [Makefile:1774: lib/yencode/AcleCrc.o] Error 1
[...]
(https://launchpad.net/ubuntu/+source/nzbget/21.0+dfsg-2ubuntu1/+build/22597345)
The compiler doesn't like the use of -march=armv8-a+crc as a target because
this override of a default target doesn't specify the presence of an FPU,
which is required for hard-float (the 'hf' in armhf).
However, the correct fix here is NOT to pass -march=armv8-a+crc+fp, because
armv8 code is not guaranteed to run on the armhf architecture! The baseline
for armhf in Debian is armv6 and in Ubuntu is armv7, so having code that
doesn't do CPU detection but is built for armv8 (or neon/simd, as appears
elsewhere in the build scripts) will generate SIGILL on various hardware
that is supposed to be supported.
I therefore think the simplest correct fix is to disable these optimizations
for armhf - if someone wants better performance on the hardware in question
they can use the arm64 build instead.
Attached is the patch I've uploaded to Ubuntu to solve this there. Please
consider applying it in Debian as well.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru nzbget-21.0+dfsg/debian/patches/armv7-only.patch
nzbget-21.0+dfsg/debian/patches/armv7-only.patch
--- nzbget-21.0+dfsg/debian/patches/armv7-only.patch 1969-12-31
16:00:00.000000000 -0800
+++ nzbget-21.0+dfsg/debian/patches/armv7-only.patch 2022-03-11
10:19:23.000000000 -0800
@@ -0,0 +1,24 @@
+Description: don't use NEON, armv8 instructions on armhf
+ The guaranteed ISA for armhf is armv7+fpu and does not include SIMD or
+ armv8. Do not try to optimize the armhf binary with these extensions;
+ users who want this should run the arm64 port.
+Author: Steve Langasek <[email protected]>
+Last-Update: 2022-03-11
+Forwarded: no
+
+Index: nzbget-21.0+dfsg/configure.ac
+===================================================================
+--- nzbget-21.0+dfsg.orig/configure.ac
++++ nzbget-21.0+dfsg/configure.ac
+@@ -572,11 +572,6 @@
+ PCLMUL_CXXFLAGS="-msse4.1 -mpclmul"
+ USE_SIMD=yes
+ ;;
+- arm*)
+- NEON_CXXFLAGS="-mfpu=neon"
+- ACLECRC_CXXFLAGS="-march=armv8-a+crc -fpermissive"
+- USE_SIMD=yes
+- ;;
+ aarch64)
+ ACLECRC_CXXFLAGS="-march=armv8-a+crc -fpermissive"
+ USE_SIMD=yes
diff -Nru nzbget-21.0+dfsg/debian/patches/series
nzbget-21.0+dfsg/debian/patches/series
--- nzbget-21.0+dfsg/debian/patches/series 2021-12-07 04:28:18.000000000
-0800
+++ nzbget-21.0+dfsg/debian/patches/series 2022-03-11 10:17:49.000000000
-0800
@@ -1,2 +1,3 @@
0001-dont-embed-libraries.patch
fips_mode.patch
+armv7-only.patch
--- End Message ---
--- Begin Message ---
Source: nzbget
Source-Version: 21.2~r2333+dfsg-1
Done: Andreas Moog <[email protected]>
We believe that the bug you reported is fixed in the latest version of
nzbget, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Moog <[email protected]> (supplier of updated nzbget package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 06 Aug 2023 19:07:23 +0200
Source: nzbget
Architecture: source
Version: 21.2~r2333+dfsg-1
Distribution: experimental
Urgency: medium
Maintainer: Andreas Moog <[email protected]>
Changed-By: Andreas Moog <[email protected]>
Closes: 928495 974451 1005717 1007134
Changes:
nzbget (21.2~r2333+dfsg-1) experimental; urgency=medium
.
* New upstream development version
.
nzbget (21.0+dfsg-3) unstable; urgency=medium
.
* Acknowledge NMU
* Use libncurses-dev for Build-Depends
* Use debhelper-compat Build-Depends
* Package complies to Standards 4.6.2
* Update copyright years
* Don't override dh_auto_install anymore
.
nzbget (21.0+dfsg-2.1) unstable; urgency=medium
.
* Non-maintainer upload.
* d/p/fips_mode.patch: Fix build against OpenSSL 3.0 Closes: #1005717
Thanks to Ubuntu developers for patch.
* Mark autopkgtest as superficial. Closes: #974451
* d/p/armv7-only.patch: Don't use NEON, armv8 instructions on armhf.
Closes: #1007134
Thanks to Ubuntu developers for patch.
.
nzbget (21.0+dfsg-2) unstable; urgency=medium
.
* Install webui libs (Closes: #928495)
.
nzbget (21.0+dfsg-1) unstable; urgency=medium
.
* New upstream Release
Checksums-Sha1:
54bee9202eb4bb3f537e74807940214ae0759711 2015 nzbget_21.2~r2333+dfsg-1.dsc
be64ea172ddce711f327c75b8bd20027291d87c7 1100184
nzbget_21.2~r2333+dfsg.orig.tar.xz
8bd8d60c1c9ad56637153924547dfe1a1e0b38d8 28356
nzbget_21.2~r2333+dfsg-1.debian.tar.xz
2f5355de03538bab2c8a73144e5fbdf142055371 6196
nzbget_21.2~r2333+dfsg-1_source.buildinfo
Checksums-Sha256:
73c29560089c3435a73def49dfe58f134e299a948ccaecc9d640914d71422819 2015
nzbget_21.2~r2333+dfsg-1.dsc
165ad251320c0171a8bd5f732bdc0cdff3a1ba376dfe4035aab28ec887e18942 1100184
nzbget_21.2~r2333+dfsg.orig.tar.xz
4a48aca6fb69e043b378520a8c2c9eedf65ff2ec2bd65ac443c6cb7169ac8a87 28356
nzbget_21.2~r2333+dfsg-1.debian.tar.xz
298a5d417d61dbfa078ef9447d4a7dd6432fdef92b1a1e6c25fb92a52411193e 6196
nzbget_21.2~r2333+dfsg-1_source.buildinfo
Files:
ee24d8392e5a4ff2c8c1fbb1ab2cd050 2015 net optional nzbget_21.2~r2333+dfsg-1.dsc
8d7cf35d31b257ccc8609eec9fd709c1 1100184 net optional
nzbget_21.2~r2333+dfsg.orig.tar.xz
ecdc32d6daae5f8058100f3ad4217bc4 28356 net optional
nzbget_21.2~r2333+dfsg-1.debian.tar.xz
58afeb2ece691e3ee5947fc5638e5246 6196 net optional
nzbget_21.2~r2333+dfsg-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJOBAEBCgA4FiEEdM3Z/lvL/g0T7o7qYfNEJnTeZiQFAmTP4SQaHGFuZHJlYXMu
bW9vZ0B3YXJwZXJiYnMuZGUACgkQYfNEJnTeZiST/w/7B0gbH9PhzVP5kTokJ9M/
6r+gkV31mraztjiuj12ji8gxM5kIBS1Fdfz3xuYQSTDa+YZ4TOqISeEVuq3YVJ1t
wsq5RNN/uEvyXw4/C898npXo2V9JXXfaleyWHX+ZKe+24XGkY/nGq5STmN59adnt
YLYVlpmSzx6C/V2xx15iXvPBZqEXWigNwn0Vh83LOxA5PpKADJtGuQogcj48QJp1
1gganaSklenxCKGUBEDZ6au0hfUiYfYa5iU1Rtq6EHntGkMNHTG4Za1oafw9U89n
uJ5xMJrifg6J/1UoYvV8Tbrmsrks9cJovgn9fHYdrINpoQRnaUXOTBIBrmLkXsDw
A0JJWUC9xBAxRRMpSXpUTwuOZqQnMcv8uuTl5wJTt1T4z8VEPueLQjkYgMBP3o+J
TMUK4lLjdIbyZOVNmeM2mjKAMn+yHb5Leh4rNUoUrwvv8WP6r81xvxmlQUCyd7Ap
1O6Jns7/8pTzop0dmjO7fBVp5v/LeTvBE1unJGA40JRVCqfkPyXhjiPqjkj2vbPf
jwSedHEcwifeOhM+4DlwvZODxhp/fOh48ACLrYkiKoQX91lt3qJ6JMfkRWdZN3SI
3kMSS8ttnhrV66B+02Y1zwEvCe6/Se/8lYkViFyvSxbfr9JTCoo5LsvSCBqGgS0U
/wbkIBdR4wp+le/ChJ4k5Yo=
=rpEw
-----END PGP SIGNATURE-----
--- End Message ---
