tags 1042289 patch
thanks
Lucas Nussbaum <lu...@debian.org> writes:
> Source: magit
> Version: 3.3.0-2
> Severity: serious
> Justification: FTBFS
> Tags: trixie sid ftbfs
> User: lu...@debian.org
> Usertags: ftbfs-20230726 ftbfs-trixie
>
> Hi,
>
> During a rebuild of all packages in sid, your package failed to build
> on amd64.
>
>
> Relevant part (hopefully):
>> make[2]: Entering directory '/<<PKGBUILDDIR>>'
>> Loading /<<PKGBUILDDIR>>/t/magit-tests.el (source)...
>> Debugger entered--Lisp error: (file-missing "Cannot open load file" "No such
>> file or directory" "compat")
>> require(compat)
>>
>> load-with-code-conversion("/usr/share/emacs/site-lisp/elpa-src/with-editor-3...."
>> "/usr/share/emacs/site-lisp/elpa-src/with-editor-3...." nil t)
>> require(with-editor)
>> load-with-code-conversion("/<<PKGBUILDDIR>>/lisp/magit-process..."
>> "/<<PKGBUILDDIR>>/lisp/magit-process..." nil t)
>> require(magit-process)
>> load-with-code-conversion("/<<PKGBUILDDIR>>/lisp/magit-transie..."
>> "/<<PKGBUILDDIR>>/lisp/magit-transie..." nil t)
>> require(magit-transient)
>> load-with-code-conversion("/<<PKGBUILDDIR>>/lisp/magit-margin...."
>> "/<<PKGBUILDDIR>>/lisp/magit-margin...." nil t)
>> require(magit-margin)
>> load-with-code-conversion("/<<PKGBUILDDIR>>/lisp/magit-core.el"
>> "/<<PKGBUILDDIR>>/lisp/magit-core.el" nil t)
>> require(magit-core)
>> load-with-code-conversion("/<<PKGBUILDDIR>>/lisp/magit.el"
>> "/<<PKGBUILDDIR>>/lisp/magit.el" nil t)
>> require(magit)
>> load-with-code-conversion("/<<PKGBUILDDIR>>/t/magit-tests.el"
>> "/<<PKGBUILDDIR>>/t/magit-tests.el" nil nil)
>> load-file("t/magit-tests.el")
>> (progn (load-file "t/magit-tests.el") (ert-run-tests-batch-and-exit))
>> command-line-1(("-L" "./lisp" "-L"
>> "/usr/share/emacs/site-lisp/elpa-src/dash-2.19.1" "-L" "./../libgit" "-L"
>> "/usr/share/emacs/site-lisp/elpa-src/transient-0.3...." "-L"
>> "/usr/share/emacs/site-lisp/elpa-src/with-editor-3...." "--eval" "(progn
>> (load-file \"t/magit-tests.el\")(ert-r..."))
>> command-line()
>> normal-top-level()
>>
>> make[2]: *** [Makefile:111: test] Error 255
>
>
> The full build log is available from:
> http://qa-logs.debian.net/2023/07/26/magit_3.3.0-2_unstable.log
>
> All bugs filed during this archive rebuild are listed at:
> https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20230726;users=lu...@debian.org
> or:
> https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20230726&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
>
> A list of current common problems and possible solutions is available at
> http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
>
> If you reassign this bug to another package, please mark it as 'affects'-ing
> this package. See https://www.debian.org/Bugs/server-control#affects
>
> If you fail to reproduce this, please provide a build log and diff it with
> mine
> so that we can identify if something relevant changed in the meantime.
>
This is due to newer with-editor starts to depend on compat while magit
hasn't done it in 3.3.0 yet. I have prepared a merge request[1] that
cherrypicks the necessary upstream commit that fixes the compat
detection, as well as a few lintian fixes. PTAL. Thanks!
[1] https://salsa.debian.org/emacsen-team/magit/-/merge_requests/2
--
Manphiz
